test: add more regex test cases

Author: timdeschryver

src/__tests__/matches.js

@@ -1,3 +1,4 @@
+import cases from 'jest-in-case'
 import {fuzzyMatches, matches} from '../matches'
 
 // unit tests for text match utils
@@ -10,12 +11,55 @@ test('matchers accept strings', () => {
  expect(fuzzyMatches('ABC', node, 'ABC', normalizer)).toBe(true)
 })
 
-test('matchers accept regex', () => {
- expect(matches('ABC', node, /ABC/, normalizer)).toBe(true)
- expect(fuzzyMatches('ABC', node, /ABC/, normalizer)).toBe(true)
-})
+cases(
+ 'matchers accept regex',
+ ({textToMatch, regex}) => {
+ expect(matches(textToMatch, node, regex, normalizer)).toBe(true)
+ expect(fuzzyMatches(textToMatch, node, regex, normalizer)).toBe(true)
+ },
+ {
+ normal: {
+ textToMatch: 'ABC',
+ regex: /ABC/,
+ },
+ global: {
+ textToMatch: 'ABC',
+ regex: /ABC/g,
+ },
+ caseInsensitive: {
+ textToMatch: 'ABC',
+ regex: /abc/i,
+ },
+ globalCaseInsensitive: {
+ textToMatch: 'AbC',
+ regex: /abc/gi,
+ },
+ multiLine: {
+ textToMatch: `
+ABC`,
+ regex: /^ABC/m,
+ },
+ dotAll: {
+ textToMatch: `AB
+C`,
+ regex: /AB.C/s,
+ },
+ unicode: {
+ textToMatch: '\u{61}',
+ regex: /\u{61}/u,
+ },
+ sticky: {
+ textToMatch: 'ABC',
+ regex: /ABC/y,
+ },
+ indecies: {
+ textToMatch: 'ABC ABC',
+ // eslint-disable-next-line no-empty-character-class
+ regex: /ABC/d,
+ },
+ },
+)
 
-// https://stackoverflow.com/questions/1520800/why-does-a-regexp-with-global-flag-give-wrong-results
 test('matchers recreate regex to prevent global mistakes', () => {
  const regex = /ABC/g
  expect(matches('ABC', node, regex, normalizer)).toBe(true)

src/matches.ts

@@ -56,6 +56,8 @@ function matches(
  if (matcher instanceof Function) {
  return matcher(normalizedText, node)
  } else if (matcher instanceof RegExp) {
+ // recreate regex to prevent state on the regex instance
+ // https://stackoverflow.com/questions/1520800/why-does-a-regexp-with-global-flag-give-wrong-results
  return new RegExp(matcher).test(normalizedText)
  } else {
  return normalizedText === String(matcher)