fix: add support for InputSignalWithTransform in inputs property #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
timdeschryver left a comment
timdeschryver left a comment There was a problem hiding this comment.
Thanks @mlz11 , I left a few comments.
apps/example-app/src/app/examples/22-signal-inputs.component.spec.ts Outdated Show resolved Hide resolved
Member
| @all-contributors please add @mlz11 for code, tests |
Contributor
| I've put up a pull request to add @mlz11! 🎉 |
| this PR breaks angular 17 application build |
| we need to either update version compatibility docs or make it v17 compatible to angular v17 @timdeschryver @mlz11 |
Member
| Please create a new issue for this @zargham-leanix |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #483
This PR adds support for
InputSignalWithTransformin theinputsproperty added by #473.