Accept query params in initialRoute property #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test: 💍 test case for new functionality
timdeschryver approved these changes Aug 17, 2023
Member
timdeschryver left a comment
timdeschryver left a comment There was a problem hiding this comment.
Thanks @jwbaart
PS: I like the emoji's in the commit messages 🤩!
Contributor Author
| @timdeschryver thanks for merging! |
Member
| @all-contributors please add @jwbaart for code, tests |
Contributor
| I've put up a pull request to add @jwbaart! 🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The initalRoute property of the render() function will now accept query parameters. This way a component can be directly loaded in query parameters dependent state without a second navigation step.
The original navigate function is split into a external & internal function were the external function will also execute a detectChanges().