fix: remove unnecessary validation block #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Although supplying incompatible network and subnetworks will not work, it is not strictly required to supply just one or the other; we should not introduce this change in behavior in 10.0 on a field that existed in 9.0.
tpdownes force-pushed the remove_validation_block branch from 94d934c to f98c46a Compare 
g-awmalik approved these changes Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Although supplying incompatible network and subnetworks will not work, it is not strictly required to supply just one or the other; we should not introduce this change in behavior in 10.0 on a field that existed in 9.0.
This validation block makes more sense in the [HPC Toolkit])(github.com/GoogleCloudPlatform), where I copied it from, but I don't think it belongs in the more general CFT modules.
Follow-up to #330.