Skip to content

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 requested review from a team, ericyz and gtsorbo as code owners July 26, 2024 02:56
@DrFaust92 DrFaust92 changed the title support supworkload_identity_config on autopilot feat: support workload_identity_config on autopilot Jul 26, 2024
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

I believe this will require bumping the minimum provider to 5.31

@DrFaust92 DrFaust92 force-pushed the workload-identity-autopilot branch from 8f22df5 to f58e78e Compare July 27, 2024 14:00
@DrFaust92
Copy link
Contributor Author

apeabody oops, saw the ref for beta for 5.33+ and missed the GA one, bumped GA as well

@DrFaust92 DrFaust92 requested a review from apeabody July 27, 2024 14:48
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody changed the title feat: support workload_identity_config on autopilot feat(TPG>=5.31)!: support workload_identity_config on autopilot Jul 29, 2024
@apeabody
Copy link
Collaborator

apeabody oops, saw the ref for beta for 5.33+ and missed the GA one, bumped GA as well

Thanks @DrFaust92 - Actually looks like this is only being added to the beta autopilot clusters? Probably want to enable to the GA variants as well?

@DrFaust92
Copy link
Contributor Author

apeabody i dont see a non beta auto pilot dir at all. is that even an option?
Screenshot 2024-07-30 at 23 12 05

@apeabody
Copy link
Collaborator

apeabody i dont see a non beta auto pilot dir at all. is that even an option? Screenshot 2024-07-30 at 23 12 05

You are correct @DrFaust92, I saw the updates to the over module's version.tf, but didn't check that they weren't Autopilot clusters. If we don't have a non-beta Autopilot clusters, we can actually revert https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/2011/files#diff-5ccc4bcabc51d0aa62a45f4a5cfe9868fb5f29fc613afa1f5a16e5c263b16d99L49, and then this should be ready to commit. Thanks!

google = {
source = "hashicorp/google"
version = ">= 5.25.0, < 6"
version = ">= 5.31.0, < 6"
Copy link
Collaborator

@apeabody apeabody Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrFaust92 - Let's revert and build, and then this should be ready to merge. (No longer a breaking change)

@apeabody apeabody changed the title feat(TPG>=5.31)!: support workload_identity_config on autopilot feat: support workload_identity_config on autopilot Jul 31, 2024
@apeabody apeabody self-assigned this Jul 31, 2024
@DrFaust92 DrFaust92 force-pushed the workload-identity-autopilot branch from f58e78e to ab17e01 Compare July 31, 2024 22:58
@DrFaust92 DrFaust92 requested a review from apeabody July 31, 2024 23:28
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Aug 1, 2024

/gcbrun

@apeabody apeabody enabled auto-merge (squash) August 1, 2024 18:52
@apeabody apeabody merged commit b4f2e14 into terraform-google-modules:master Aug 1, 2024
DrFaust92 added a commit to DrFaust92/terraform-google-kubernetes-engine that referenced this pull request Aug 2, 2024
…-modules#2011) Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants