fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…firewall rules toggled on
…s a fw's target tag
…rrection to readme
| @apeabody can we try once more :) |
| /gcbrun |
| /gcbrun |
apeabody reviewed Jun 13, 2024
test/integration/autopilot_private_firewalls/autopilot_private_firewalls_test.go Show resolved Hide resolved
I do see a |
Ah thanks @apeabody for posting this, lead me to notice my test code was trimming the -cluster suffix from the clusterName, no idea why I did that. Have pushed fix. |
| /gcbrun |
|
apeabody reviewed Jun 17, 2024
set deletion_protection to false Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
| /gcbrun |
| @apeabody need anything else from my end? |
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 26, 2024
While terraform-google-modules#1817 added autopilot support for adding tags to `node_pool_auto_config` when `add_cluster_firewall_rules` is set to `true`, the same change did not apply for standard (non-autopilot) clusters with cluster level autoscaling (nodepool autoprovisioning) in place, Fixes terraform-google-modules#2104 Signed-off-by: William Yardley <wyardley@users.noreply.github.com>
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 26, 2024
While terraform-google-modules#1817 added autopilot support for adding tags to `node_pool_auto_config` when `add_cluster_firewall_rules` is set to `true`, the same change did not apply for standard (non-autopilot) clusters with cluster level autoscaling (nodepool autoprovisioning) in place, Fixes terraform-google-modules#2104 Signed-off-by: William Yardley <wyardley@users.noreply.github.com>
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 26, 2024
While terraform-google-modules#1817 added autopilot support for adding tags to `node_pool_auto_config` when `add_cluster_firewall_rules` is set to `true`, the same change did not apply for standard (non-autopilot) clusters with cluster level autoscaling (nodepool autoprovisioning) in place, Fixes terraform-google-modules#2104 Signed-off-by: William Yardley <wyardley@users.noreply.github.com>
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 27, 2024
While terraform-google-modules#1817 added autopilot support for adding tags to `node_pool_auto_config` when `add_cluster_firewall_rules` is set to `true`, the same change did not apply for standard (non-autopilot) clusters with cluster level autoscaling (nodepool autoprovisioning) in place, Fixes terraform-google-modules#2104 Signed-off-by: William Yardley <wyardley@users.noreply.github.com>
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 27, 2024
While terraform-google-modules#1817 added autopilot support for adding tags to `node_pool_auto_config` when `add_cluster_firewall_rules` is set to `true`, the same change did not apply for standard (non-autopilot) clusters with cluster level autoscaling (nodepool autoprovisioning) in place, Fixes terraform-google-modules#2104 Signed-off-by: William Yardley <wyardley@users.noreply.github.com>
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 27, 2024
While terraform-google-modules#1817 added autopilot support for adding tags to `node_pool_auto_config` when `add_cluster_firewall_rules` is set to `true`, the same change did not apply for standard (non-autopilot) clusters with cluster level autoscaling (nodepool autoprovisioning) in place, Fixes terraform-google-modules#2104 Signed-off-by: William Yardley <wyardley@users.noreply.github.com>
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Oct 9, 2024
While terraform-google-modules#1817 added autopilot support for adding tags to `node_pool_auto_config` when `add_cluster_firewall_rules` is set to `true`, the same change did not apply for standard (non-autopilot) clusters with cluster level autoscaling (nodepool autoprovisioning) in place, Fixes terraform-google-modules#2104 Signed-off-by: William Yardley <wyardley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
add_cluster_firewall_rules,add_master_webhook_firewall_rulesoradd_shadow_firewall_rulesare toggled true.