4.6.0 Rendering Changes article #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| We must review and merge this PR first #1664 so that the checks here can pass. |
dimodi reviewed Oct 10, 2023
| position: 1 | ||
| --- | ||
| | ||
| # Rendering Changes in 4.6.0 |
Contributor
There was a problem hiding this comment.
How are the components sorted? It's not alphabetically, by importance or by number of changes.
Contributor Author
There was a problem hiding this comment.
I wanted a "special" sort - Icons first, and then alphabetically, but swapped the Filter and Form. I have fixed that.
dimodi reviewed Oct 10, 2023
| <td style="vertical-align:top"> | ||
| <pre><code> | ||
| <span class="k-icon k-i-home"></span> | ||
| <span class="k-svg-icon k-svg-i-home"></span> |
Contributor
There was a problem hiding this comment.
Ideally, the before-after snippets should have the same number of lines. The SVG span doesn't follow this best practice.
dimodi approved these changes Oct 10, 2023
svdimitr force-pushed the 460-rendering-changes branch from 211d3d2 to 2c7ab34 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/telerik/blazor/issues/6345