Skip to content

Conversation

@svdimitr
Copy link
Contributor

@svdimitr svdimitr commented Oct 6, 2023

@svdimitr svdimitr requested a review from a team October 6, 2023 07:55
@svdimitr svdimitr self-assigned this Oct 6, 2023
@svdimitr svdimitr marked this pull request as ready for review October 10, 2023 10:49
@svdimitr svdimitr requested a review from a team as a code owner October 10, 2023 10:49
svdimitr and others added 3 commits October 10, 2023 14:10
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
<link href="https://blazor.cdn.telerik.com/blazor/4.6.0/kendo-font-icons/font-icons.css" rel="stylesheet" type="text/css" />
````

* Download the [Telerik UI for Blazor package]({%slug installation/msi%}#how-to-download-the-automated-installer) and reference the static assets for the Font Icons:
Copy link
Contributor

@dimodi dimodi Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The download step should be unnecessary. Customers already have the package. It makes more sense to mention Trial vs non-Trial URLs here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the Trial version of the static assets reference.

I have added this step to "cover all bases". I would like it to stay in the article.


The 7.0.0 version of the Kendo UI Themes is a dependency in Telerik UI for Blazor 4.6.0; thus, the font icons are missing.

## Solution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to duplicate the examples for index.html and _Host.cshtml. It may be easier to just mention that the new stylesheet should be added where the theme is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, foolproof to prevent any misunderstandings. I didi this to be on the safe-side due to previous mishaps with Icons (4.0.0). If you believe that it is redundant I can remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense to encourage users to click on a tab and see the same code. I would clarify the required file before the snippet.

Copy link
Contributor Author

@svdimitr svdimitr Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the duplicates


## Description

After upgrading to the 4.6.0 version of the Telerik UI for Blazor suite the Font Icons in my application are not longer showing (rendering).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link the font icons article somewhere in the article content and also add it as a See Also item.

Consider linking this KB from the Font Icons page and Rendering Changes for more incoming traffic. Customers may refer to the existing browsable articles when they hit an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already linked in the 4.6.0 Rendering changes article (another PR currently). Right now I try to think of the best possible place in the Icons article to link the KB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a link to the KB in the Icons article

@svdimitr svdimitr requested a review from dimodi October 10, 2023 12:15
@svdimitr svdimitr merged commit 79bc1a5 into master Oct 10, 2023
@github-actions github-actions bot deleted the font-icons-detatched branch October 10, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants