- Notifications
You must be signed in to change notification settings - Fork 80
Documentation on missing font icons in 4.6.0 #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
| <link href="https://blazor.cdn.telerik.com/blazor/4.6.0/kendo-font-icons/font-icons.css" rel="stylesheet" type="text/css" /> | ||
| ```` | ||
| | ||
| * Download the [Telerik UI for Blazor package]({%slug installation/msi%}#how-to-download-the-automated-installer) and reference the static assets for the Font Icons: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The download step should be unnecessary. Customers already have the package. It makes more sense to mention Trial vs non-Trial URLs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the Trial version of the static assets reference.
I have added this step to "cover all bases". I would like it to stay in the article.
| | ||
| The 7.0.0 version of the Kendo UI Themes is a dependency in Telerik UI for Blazor 4.6.0; thus, the font icons are missing. | ||
| | ||
| ## Solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to duplicate the examples for index.html and _Host.cshtml. It may be easier to just mention that the new stylesheet should be added where the theme is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, foolproof to prevent any misunderstandings. I didi this to be on the safe-side due to previous mishaps with Icons (4.0.0). If you believe that it is redundant I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make sense to encourage users to click on a tab and see the same code. I would clarify the required file before the snippet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the duplicates
| | ||
| ## Description | ||
| | ||
| After upgrading to the 4.6.0 version of the Telerik UI for Blazor suite the Font Icons in my application are not longer showing (rendering). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link the font icons article somewhere in the article content and also add it as a See Also item.
Consider linking this KB from the Font Icons page and Rendering Changes for more incoming traffic. Customers may refer to the existing browsable articles when they hit an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already linked in the 4.6.0 Rendering changes article (another PR currently). Right now I try to think of the best possible place in the Icons article to link the KB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a link to the KB in the Icons article
Related to: https://github.com/telerik/blazor/issues/7485