Update strip-html-on-paste.md #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The punctuation at the end of lists should generally be a period, not a semi-colon. I think the markdown for a numbered list is to begin each line with a 1. but you specifically numbered them at 1. 2. 3. 4. I left it but decided to leave you this comment to check the syntax. The description of the article says that the article teaches how to strip "some" HTML but the actual body of the article does not suggest that there are limitations. Can this technique strip some kinds of HTML but not others? Perhaps add a note about that?
Contributor
| Ordered list in MD can be created by using both approaches and both of them are valid. As for stripping the HTML, what limitation could be there. The actual stripping relies entirely on what developer would implement. Thus, it will strip only the HTML he needs to and nothing more. I am not sure what comment could be put here on that matter. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The punctuation at the end of lists should generally be a period, not a semi-colon.
I think the markdown for a numbered list is to begin each line with a 1. but you specifically numbered them at 1. 2. 3. 4. I left it but decided to leave you this comment to check the syntax.
The description of the article says that the article teaches how to strip "some" HTML but the actual body of the article does not suggest that there are limitations. Can this technique strip some kinds of HTML but not others? Perhaps add a note about that?