Skip to content

utubettl: remove unnecessary on_task_change call #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

utubettl: remove unnecessary on_task_change call #97

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
054b552
utubettl: remove unnecessary on_task_change call
Sep 6, 2019
cae6b85
utubettl: if the task being deleted was not taken, do not wake neighb…
Sep 19, 2019
5168381
utubettl: review fixes
Jul 24, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions queue/abstract/driver/utubettl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,8 @@ end
local function process_neighbour(self, task, operation)
self:on_task_change(task, operation)
if task ~= nil then
local neighbour = self.space.index.utube:min{state.READY, task[i_utube]}
if neighbour ~= nil and neighbour[i_status] == state.READY then
local neighbour = self.space.index.utube:select({state.READY, task[i_utube]}, {limit=1})[1]
if neighbour ~= nil then
self:on_task_change(neighbour)
end
end
Expand All @@ -304,10 +304,16 @@ end
-- delete task
function method.delete(self, id)
local task = self.space:get(id)
self.space:delete(id)
if task ~= nil then
local is_taken = task[i_status] == state.TAKEN
self.space:delete(id)
task = task:transform(i_status, 1, state.DONE)
return process_neighbour(self, task, 'delete')
if is_taken then
return process_neighbour(self, task, 'delete')
else
self:on_task_change(task, 'delete')
return task
end
end
self:on_task_change(task, 'delete')
end
Expand Down