avoid unneeded :transform in tube.delete #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
All the queue drivers do `:transform(2, 1, state.DONE)` before returning the task from their `.delete` method.
Contributor
| This is needed to notify the user that task is successfully done. Why is it bothering you? |
Contributor Author
| @bigbes The queue drivers already do that in their queue/queue/abstract/driver/fifo.lua Line 80 in 593c9f6 queue/queue/abstract/driver/fifottl.lua Line 296 in 593c9f6 queue/queue/abstract/driver/utube.lua Line 95 in 593c9f6 queue/queue/abstract/driver/utubettl.lua Line 309 in 593c9f6 |
Contributor
| LGTM |
Contributor
| Continue #118 |
Contributor
| Closed in favor of #118. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
All the queue drivers do
:transform(2, 1, state.DONE)before returning the task from their.deletemethod.