fix custom driver registration after reboot #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LeonidVas force-pushed the lvasiliev/gh-137-custom-driver-registration branch from aaba414 to a7a221a Compare 
ligurio suggested changes Nov 11, 2020
Previously, if a custom driver is registered after calling box.cfg() it causes a problem when the instance will be restarted. The cause of the problem is an attempt to recreate a tube of custom type (which is not registered yet). This bug is now fixed. Fixes #137
LeonidVas force-pushed the lvasiliev/gh-137-custom-driver-registration branch from a7a221a to 65b1683 Compare 
Totktonada reviewed Nov 12, 2020
Totktonada approved these changes Nov 12, 2020
Contributor
Totktonada left a comment
Totktonada left a comment There was a problem hiding this comment.
I didn't looked at the code thoroughly, but the idea looks good for me.
ligurio approved these changes Nov 13, 2020
Member
ligurio left a comment
ligurio left a comment There was a problem hiding this comment.
Leonid, thanks for the patch!
LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously, if a custom driver is registered after calling box.cfg() it causes a problem when the instance will be restarted. The cause of the problem is an attempt to recreate a tube of custom type (which is not registered yet).
This bug is now fixed.
Fixes #137
@ChangeLog: fix custom driver registration after reboot. Previously, if a custom driver is registered after calling box.cfg() it causes a problem when the instance will be restarted. The cause of the problem is an attempt to recreate a tube of custom type (which is not registered yet).