Fix release all tasks #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Added return in case of tarantool version < 1.7.5 * Instead of nil, an empty table is used as "opts" argument of the driver "release" method. This is the policy of the module "queue": "Check opts in abstract.lua, instead to check inside the driver". Fixes #121
Totktonada approved these changes Jul 27, 2020
Contributor
Totktonada left a comment
Totktonada left a comment There was a problem hiding this comment.
LGTM.
Please, add an entry for changelog to the PR.
Totktonada reviewed Jul 27, 2020
rybakit reviewed Jul 27, 2020
LeonidVas force-pushed the lvasiliev/gh-121-fix-release-all-tasks branch from 73466d2 to a18101c Compare 
Contributor Author
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow-up #66
Fixes #121
ChangeLog: fix the tasks releases on start for some drivers(utubettl, fifottl, limfifottl). Before, an attempt to release "taken" tasks on start lead to an error:"attempt to index local 'opts' (a nil value)".