Skip to content

Conversation

@printercu
Copy link
Contributor

No description provided.

@printercu printercu marked this pull request as ready for review November 29, 2019 14:39
Copy link
Contributor

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing of duplication in .travis.yml is great, thanks!

I'm tentative about splitting jobs to testing and deploy stages, because stages are run sequentially: this will increase overall time of the pipeline. However queue tests are quite small and it does not matter much. So, I'm okay if there are no other way to reduce text duplication here.

Let's add 'travis-ci:' prefix to the commit message: it is useful when looking over commits to filter out ones that do not change code or tests.

Will you add a commit re publishing rockspec to our repository? Now the PR is named 'Publish rockspec automatically', while it contains just .travis.yml rewriting.

@printercu
Copy link
Contributor Author

I've split deployment from tests because deployment includes building packages with packpack. This takes quite long. Now it runs tests for 3 Tarantool versions in push travis job, if it succeed it runs tests in pr travis job and only then starts building packages.

I've also added commit for publishing rockspecs.

@Totktonada
Copy link
Contributor

I wrote it in assumption that we run tests in packpack jobs itself, but now I see that it is so only in Debian / Ubuntu jobs, while test are not run in CentOS / Fedora jobs. Okay for splitting stages so.

Copy link
Contributor

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's add 'travis-ci' prefixes for commit messages.

If possible, please, set a jobs name for rockspec upload jobs for Travis-CI web UI.

@printercu printercu merged commit a812c10 into master Dec 2, 2019
@Totktonada Totktonada deleted the publish_rockspec branch December 2, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants