Skip to content

why call on_task_change with nil? #74

@aleclarson

Description

@aleclarson

else
self.on_task_change(task, 'delete')
end

We shouldn't call on_task_change(nil, 'delete') since a nil task indicates the task has already been removed from the queue, which means on_task_change was already called before when the task was previously deleted or acknowledged.

I assume this is being done in other queue types, too.

I'll send a pull request if you agree.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions