- Notifications
You must be signed in to change notification settings - Fork 14
cd: add package deploy workflow #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @LeonidVas , please add I'll be waiting for approve from you here. |
LeonidVas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for the patchset.
If it works fine I'm ok.
See sevearal comments bellow:
packages: fix tarantool-checks dependencyin commit body:because we because we are- Do we need to downgrade
checksif we don't havecheck< 3.0.0 in the repositories? ci: add package deploy workflow->cd: ...- check that all works fine by using https://rws-dev.tarantool.org/
The patch adds tarantool-checks runtime dependency for rpm/dep packages. It also decreases required tarantool-check version to 2.1 because we are compatible with it in fact. Part of #124
We don't have the tarantool-luatest package in any public repository for all supported distros. We have to skip the test step until the tarantool-luatest is built at least for S3 repository. Closes #124
Build systems install build dependencies using a default distro repo. It may an be outdated, broken or missed Tarantool package. To provide the latest version of Tarantool 1.10 (the latest of the lower supported version), `prebuild.sh` script wich installs Tarantool repo was added to packages spec folders. Part of #43
7ceb344 to 303c0b5 Compare | Thank you for the review!
Thank you, fixed!
I don't see any drawbacks, It will just install the >= 3.0.0 from a repo . But if the user needs to use the version 2.1 for some reason then he can do it. Also
We use
Is there any way to do it safely? It seems to me the safest way would be to wait for the next tag, so as not to overwrite artifacts on the current one. So my plan:
|
While we are not testing it with checks 2.0.0 , we don't know when it will break. Up to you.
It's not correct. Up to you.
This is bad practice, and I see no reason to wait for releases in this case. For this purpose,
If you don't understand how to test, ping me. |
8580fcb to 88f64c9 Compare
Oh, I got it. Thank you! I didn't pay attention to It works. There were two jobs (push + pull request), so duplication 17 + 18 is ok: |
This workflow is intended to run on a tag push for creating and deploying module packages to S3 based repositories. Closes #43
88f64c9 to 65d81ac Compare
GRISHNOV left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! LGTM
This workflow is intended to run on a tag push for creating and deploying module packages to S3 based repositories.
We don't have the tarantool-luatest package in any public repository for all supported distros. We have to skip the test step until the tarantool-luatest is built at least for S3 repository.
It also fixed tarantool-checks dependency for deb/rpm packages, decreases required tarantool-checks from 3.1 to 2.1.
See other similar pull requests:
tarantool/queue#157 , tarantool/http#164
Closes #43
Closes #124