Skip to content

Commit e96a016

Browse files
committed
Merge pull request aeron-io#201 from csoroiu/master
added failonerror and fork to build files and a small fix for the javagenerator
2 parents e2e99b0 + e30a32b commit e96a016

File tree

7 files changed

+31
-29
lines changed

7 files changed

+31
-29
lines changed

build.xml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@
610610
<target name="generate:java:sbeir-stubs"
611611
depends="dist"
612612
description="Generate serialized IR stubs for Java">
613-
<java classname="uk.co.real_logic.sbe.SbeTool">
613+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
614614
<classpath refid="sbetool.classpath"/>
615615
<sysproperty key="sbe.output.dir" value="${dir.main.src}"/>
616616
<sysproperty key="sbe.target.language" value="Java"/>
@@ -621,7 +621,7 @@
621621
<target name="generate:cpp98:sbeir-stubs"
622622
depends="dist"
623623
description="Generate serialized IR stubs for C++98">
624-
<java classname="uk.co.real_logic.sbe.SbeTool">
624+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
625625
<classpath refid="sbetool.classpath"/>
626626
<sysproperty key="sbe.output.dir" value="${dir.main.cpp.src}"/>
627627
<sysproperty key="sbe.target.language" value="cpp98"/>
@@ -632,7 +632,7 @@
632632
<target name="generate:csharp:sbeir-stubs"
633633
depends="dist"
634634
description="Generate serialized IR stubs for C#">
635-
<java classname="uk.co.real_logic.sbe.SbeTool">
635+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
636636
<classpath refid="sbetool.classpath"/>
637637
<sysproperty key="sbe.output.dir" value="${dir.main.csharp.src}"/>
638638
<sysproperty key="sbe.target.language" value="csharp"/>
@@ -669,7 +669,7 @@
669669
depends="dist">
670670
<mkdir dir="${dir.gen.java}"/>
671671
<mkdir dir="${dir.examples.build}"/>
672-
<java classname="uk.co.real_logic.sbe.SbeTool">
672+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
673673
<classpath refid="examples.classpath"/>
674674
<sysproperty key="sbe.validation.xsd" value="main/resources/fpl/SimpleBinary1-0.xsd"/>
675675
<sysproperty key="sbe.validation.stop.on.error" value="true"/>
@@ -684,13 +684,13 @@
684684
<javac srcdir="${dir.examples.src}" destdir="${dir.examples.build}" includeAntRuntime="false" debug="true">
685685
<classpath refid="examples.classpath"/>
686686
</javac>
687-
<java classname="uk.co.real_logic.sbe.examples.ExampleUsingGeneratedStub">
687+
<java classname="uk.co.real_logic.sbe.examples.ExampleUsingGeneratedStub" failonerror="true" fork="true">
688688
<classpath refid="examples.classpath"/>
689689
</java>
690-
<java classname="uk.co.real_logic.sbe.examples.ExampleUsingGeneratedStubExtension">
690+
<java classname="uk.co.real_logic.sbe.examples.ExampleUsingGeneratedStubExtension" failonerror="true" fork="true">
691691
<classpath refid="examples.classpath"/>
692692
</java>
693-
<java classname="uk.co.real_logic.sbe.examples.OtfExample">
693+
<java classname="uk.co.real_logic.sbe.examples.OtfExample" failonerror="true" fork="true">
694694
<classpath refid="examples.classpath"/>
695695
</java>
696696
</target>
@@ -699,7 +699,7 @@
699699
depends="dist"
700700
description="Generate and run C++ generated code example">
701701
<mkdir dir="${dir.gen.cpp98}"/>
702-
<java classname="uk.co.real_logic.sbe.SbeTool">
702+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
703703
<classpath refid="examples.classpath"/>
704704
<sysproperty key="sbe.output.dir" value="${dir.gen.cpp98}"/>
705705
<sysproperty key="sbe.target.language" value="cpp98"/>
@@ -755,14 +755,14 @@
755755
<fileset dir="${dir.main.cpp.build}" includes="*.o*"/>
756756
<fileset dir="${dir.examples.cpp98.src}" includes="SbeOtfDecoder.cpp"/>
757757
</cc>
758-
<java classname="uk.co.real_logic.sbe.SbeTool">
758+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
759759
<classpath refid="examples.classpath"/>
760760
<sysproperty key="sbe.output.dir" value="${dir.gen.cpp98}"/>
761761
<sysproperty key="sbe.generate.stubs" value="false"/>
762762
<sysproperty key="sbe.generate.ir" value="true"/>
763763
<arg value="${dir.examples.resources}/example-schema.xml"/>
764764
</java>
765-
<java classname="uk.co.real_logic.sbe.examples.ExampleUsingGeneratedStub">
765+
<java classname="uk.co.real_logic.sbe.examples.ExampleUsingGeneratedStub" failonerror="true" fork="true">
766766
<classpath refid="examples.classpath"/>
767767
<sysproperty key="sbe.encoding.filename" value="${dir.gen.cpp98}/Car.data"/>
768768
</java>
@@ -851,23 +851,23 @@
851851
<target name="cpp:test:codegen" depends="dist">
852852
<sequential>
853853
<mkdir dir="${dir.gen.cpp98}"/>
854-
<java classname="uk.co.real_logic.sbe.SbeTool">
854+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
855855
<classpath refid="examples.classpath"/>
856856
<sysproperty key="sbe.output.dir" value="${dir.gen.cpp98}"/>
857857
<sysproperty key="sbe.target.language" value="cpp98"/>
858858
<sysproperty key="sbe.generate.ir" value="true"/>
859859
<arg value="${dir.test.resources}/code-generation-schema-cpp.xml"/>
860860
</java>
861861
<copy file="${dir.gen.cpp98}/code-generation-schema-cpp.sbeir" todir="${dir.exec.test.cpp}"/>
862-
<java classname="uk.co.real_logic.sbe.SbeTool">
862+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
863863
<classpath refid="examples.classpath"/>
864864
<sysproperty key="sbe.output.dir" value="${dir.gen.cpp98}"/>
865865
<sysproperty key="sbe.target.language" value="cpp98"/>
866866
<sysproperty key="sbe.generate.ir" value="true"/>
867867
<arg value="${dir.test.resources}/composite-offsets-schema.xml"/>
868868
</java>
869869
<copy file="${dir.gen.cpp98}/composite-offsets-schema.sbeir" todir="${dir.exec.test.cpp}"/>
870-
<java classname="uk.co.real_logic.sbe.SbeTool">
870+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
871871
<classpath refid="examples.classpath"/>
872872
<sysproperty key="sbe.output.dir" value="${dir.gen.cpp98}"/>
873873
<sysproperty key="sbe.target.language" value="cpp98"/>

main/csharp/ir/generated/FrameCodec.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public sealed partial class FrameCodec
1212
public const ushort TemplateId = (ushort)1;
1313
public const ushort SchemaId = (ushort)0;
1414
public const ushort Schema_Version = (ushort)0;
15-
public const string SematicType = "";
15+
public const string SemanticType = "";
1616

1717
private readonly FrameCodec _parentMessage;
1818
private DirectBuffer _buffer;

main/csharp/ir/generated/TokenCodec.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public sealed partial class TokenCodec
1212
public const ushort TemplateId = (ushort)2;
1313
public const ushort SchemaId = (ushort)0;
1414
public const ushort Schema_Version = (ushort)0;
15-
public const string SematicType = "";
15+
public const string SemanticType = "";
1616

1717
private readonly TokenCodec _parentMessage;
1818
private DirectBuffer _buffer;

main/java/uk/co/real_logic/sbe/generation/java/JavaGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1160,7 +1160,7 @@ private CharSequence generateMessageFlyweightCode(final String className, final
11601160
" limit(offset + actingBlockLength);\n\n" +
11611161
" return this;\n" +
11621162
" }\n\n" +
1163-
" public %9$s wrapForDecode(" +
1163+
" public %9$s wrapForDecode(\n" +
11641164
" final DirectBuffer buffer, final int offset, final int actingBlockLength, final int actingVersion)\n" +
11651165
" {\n" +
11661166
" this.buffer = buffer;\n" +
@@ -1442,4 +1442,4 @@ private String generateLiteral(final PrimitiveType type, final String value)
14421442

14431443
return literal;
14441444
}
1445-
}
1445+
}

main/java/uk/co/real_logic/sbe/ir/generated/FrameCodec.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ public FrameCodec wrapForEncode(final DirectBuffer buffer, final int offset)
5858
return this;
5959
}
6060

61-
public FrameCodec wrapForDecode(final DirectBuffer buffer, final int offset, final int actingBlockLength, final int actingVersion)
61+
public FrameCodec wrapForDecode(
62+
final DirectBuffer buffer, final int offset, final int actingBlockLength, final int actingVersion)
6263
{
6364
this.buffer = buffer;
6465
this.offset = offset;

main/java/uk/co/real_logic/sbe/ir/generated/TokenCodec.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ public TokenCodec wrapForEncode(final DirectBuffer buffer, final int offset)
5858
return this;
5959
}
6060

61-
public TokenCodec wrapForDecode(final DirectBuffer buffer, final int offset, final int actingBlockLength, final int actingVersion)
61+
public TokenCodec wrapForDecode(
62+
final DirectBuffer buffer, final int offset, final int actingBlockLength, final int actingVersion)
6263
{
6364
this.buffer = buffer;
6465
this.offset = offset;

perf-build.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@
4242
</target>
4343

4444
<target name="java:codegen" depends="init">
45-
<java classname="uk.co.real_logic.sbe.SbeTool">
45+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
4646
<classpath refid="perf.tools.classpath"/>
4747
<sysproperty key="sbe.output.dir" value="${dir.target.perf.java}"/>
4848
<sysproperty key="sbe.target.language" value="Java"/>
4949
<arg value="${dir.resources.sbe}/car.xml"/>
5050
</java>
51-
<java classname="uk.co.real_logic.sbe.SbeTool">
51+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
5252
<classpath refid="perf.tools.classpath"/>
5353
<sysproperty key="sbe.output.dir" value="${dir.target.perf.java}"/>
5454
<sysproperty key="sbe.target.language" value="Java"/>
@@ -57,7 +57,7 @@
5757

5858
<fail unless="protobuf.home" message="protobuf.home is not defined (please add a build-local.properties and define it."/>
5959

60-
<exec executable="${protobuf.home}/bin/protoc">
60+
<exec executable="${protobuf.home}/bin/protoc" failonerror="true">
6161
<arg value="-I${dir.resources.protobuf}"/>
6262
<arg value="--java_out"/>
6363
<arg value="${dir.target.perf.java}"/>
@@ -88,7 +88,7 @@
8888
</target>
8989

9090
<target name="java:perf:test" depends="java:compile">
91-
<exec executable="java">
91+
<exec executable="java" failonerror="true">
9292
<arg value="-jar"/>
9393
<arg value="target/perf/dist/microbenchmarks.jar"/>
9494
<arg value="-wi"/>
@@ -100,13 +100,13 @@
100100
</target>
101101

102102
<target name="cpp:codegen" depends="init">
103-
<java classname="uk.co.real_logic.sbe.SbeTool">
103+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
104104
<classpath refid="perf.tools.classpath"/>
105105
<sysproperty key="sbe.output.dir" value="${dir.target.perf.cpp}"/>
106106
<sysproperty key="sbe.target.language" value="Cpp98"/>
107107
<arg value="${dir.resources.sbe}/car-c.xml"/>
108108
</java>
109-
<java classname="uk.co.real_logic.sbe.SbeTool">
109+
<java classname="uk.co.real_logic.sbe.SbeTool" failonerror="true" fork="true">
110110
<classpath refid="perf.tools.classpath"/>
111111
<sysproperty key="sbe.output.dir" value="${dir.target.perf.cpp}"/>
112112
<sysproperty key="sbe.target.language" value="Cpp98"/>
@@ -116,17 +116,17 @@
116116

117117
<target name="cpp:compile" depends="clean, init, cpp:codegen">
118118
<sequential>
119-
<exec executable="cmake" dir="target/perf">
119+
<exec executable="cmake" dir="target/perf" failonerror="true">
120120
<arg value="../../perf/cpp"/>
121121
</exec>
122-
<exec executable="make" dir="target/perf"/>
122+
<exec executable="make" dir="target/perf" failonerror="true"/>
123123
</sequential>
124124
</target>
125125

126126
<target name="cpp:perf:test" depends="cpp:compile">
127127
<sequential>
128-
<exec executable="target/perf/benchlet-sbe-md-runner"/>
129-
<exec executable="target/perf/benchlet-sbe-car-runner"/>
128+
<exec executable="target/perf/benchlet-sbe-md-runner" failonerror="true"/>
129+
<exec executable="target/perf/benchlet-sbe-car-runner" failonerror="true"/>
130130
</sequential>
131131
</target>
132132

0 commit comments

Comments
 (0)