fix different constant arrays counts

Author: staabm

src/Type/Php/ArrayCombineFunctionReturnTypeExtension.php

@@ -51,14 +51,11 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 
 $constantKeysArrays = $keysParamType->getConstantArrays();
 $constantValuesArrays = $valuesParamType->getConstantArrays();
-if ($constantKeysArrays !== [] && $constantValuesArrays !== []) {
-if (count($constantKeysArrays) !== count($constantValuesArrays)) {
-if ($this->phpVersion->throwsTypeErrorForInternalFunctions()) {
-return new NeverType();
-}
-return new ConstantBooleanType(false);
-}
-
+if (
+$constantKeysArrays !== []
+&& $constantValuesArrays !== []
+&& count($constantKeysArrays) === count($constantValuesArrays)
+) {
 $results = [];
 foreach ($constantKeysArrays as $k => $constantKeysArray) {
 $constantValueArrays = $constantValuesArrays[$k];

tests/PHPStan/Analyser/nsrt/array-combine-php8.php

@@ -96,6 +96,23 @@ function withUnionConstArraysDifferentKeyValueCount(): void
 assertType("*NEVER*", array_combine($a, $b));
 }
 
+function withUnionConstArraysDifferentArraysCount(): void
+{
+if (rand(0, 1)) {
+$a = [1];
+$b = ['avocado'];
+} else {
+$a = ["2", "3"];
+if (rand(0, 1)) {
+$b = ['apple', 'banana'];
+} else {
+$b = ['banana', 'pear'];
+}
+}
+
+assertType("non-empty-array<1|'2'|'3', 'apple'|'avocado'|'banana'|'pear'>", array_combine($a, $b));
+}
+
 /**
  * @param non-empty-array<int, 'foo'|'bar'|'baz'> $a
  * @param non-empty-array<int, 'apple'|'avocado'|'banana'> $b