Skip to content

Commit ea391d7

Browse files
committed
refactor(theme-shared): add status enum to confirmation model and use it instead of toaster status enum
1 parent 7c15623 commit ea391d7

File tree

3 files changed

+19
-15
lines changed

3 files changed

+19
-15
lines changed

npm/ng-packs/packages/theme-shared/src/lib/components/confirmation/confirmation.component.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,16 @@ import { Component } from '@angular/core';
22
import { ConfirmationService } from '../../services/confirmation.service';
33
import { Confirmation } from '../../models/confirmation';
44
import { LocalizationService } from '@abp/ng.core';
5-
import { Toaster } from '../../models/toaster';
65

76
@Component({
87
selector: 'abp-confirmation',
98
templateUrl: './confirmation.component.html',
109
styleUrls: ['./confirmation.component.scss'],
1110
})
1211
export class ConfirmationComponent {
13-
confirm = Toaster.Status.confirm;
14-
reject = Toaster.Status.reject;
15-
dismiss = Toaster.Status.dismiss;
12+
confirm = Confirmation.Status.confirm;
13+
reject = Confirmation.Status.reject;
14+
dismiss = Confirmation.Status.dismiss;
1615

1716
visible = false;
1817

@@ -43,7 +42,7 @@ export class ConfirmationComponent {
4342
});
4443
}
4544

46-
close(status: Toaster.Status) {
45+
close(status: Confirmation.Status) {
4746
this.confirmationService.clear(status);
4847
}
4948
}

npm/ng-packs/packages/theme-shared/src/lib/models/confirmation.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,10 @@ export namespace Confirmation {
2020
}
2121

2222
export type Severity = 'neutral' | 'success' | 'info' | 'warning' | 'error';
23+
24+
export enum Status {
25+
confirm = 'confirm',
26+
reject = 'reject',
27+
dismiss = 'dismiss',
28+
}
2329
}

npm/ng-packs/packages/theme-shared/src/lib/services/confirmation.service.ts

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,52 +2,51 @@ import { Injectable } from '@angular/core';
22
import { Confirmation } from '../models/confirmation';
33
import { fromEvent, Observable, Subject, ReplaySubject } from 'rxjs';
44
import { takeUntil, debounceTime, filter } from 'rxjs/operators';
5-
import { Toaster } from '../models/toaster';
65
import { Config } from '@abp/ng.core';
76

87
@Injectable({ providedIn: 'root' })
98
export class ConfirmationService {
10-
status$: Subject<Toaster.Status>;
9+
status$: Subject<Confirmation.Status>;
1110
confirmation$ = new ReplaySubject<Confirmation.DialogData>(1);
1211

1312
info(
1413
message: Config.LocalizationParam,
1514
title: Config.LocalizationParam,
1615
options?: Partial<Confirmation.Options>,
17-
): Observable<Toaster.Status> {
16+
): Observable<Confirmation.Status> {
1817
return this.show(message, title, 'info', options);
1918
}
2019

2120
success(
2221
message: Config.LocalizationParam,
2322
title: Config.LocalizationParam,
2423
options?: Partial<Confirmation.Options>,
25-
): Observable<Toaster.Status> {
24+
): Observable<Confirmation.Status> {
2625
return this.show(message, title, 'success', options);
2726
}
2827

2928
warn(
3029
message: Config.LocalizationParam,
3130
title: Config.LocalizationParam,
3231
options?: Partial<Confirmation.Options>,
33-
): Observable<Toaster.Status> {
32+
): Observable<Confirmation.Status> {
3433
return this.show(message, title, 'warning', options);
3534
}
3635

3736
error(
3837
message: Config.LocalizationParam,
3938
title: Config.LocalizationParam,
4039
options?: Partial<Confirmation.Options>,
41-
): Observable<Toaster.Status> {
40+
): Observable<Confirmation.Status> {
4241
return this.show(message, title, 'error', options);
4342
}
4443

4544
show(
4645
message: Config.LocalizationParam,
4746
title: Config.LocalizationParam,
48-
severity?: Toaster.Severity,
47+
severity?: Confirmation.Severity,
4948
options?: Partial<Confirmation.Options>,
50-
): Observable<Toaster.Status> {
49+
): Observable<Confirmation.Status> {
5150
this.confirmation$.next({
5251
message,
5352
title,
@@ -59,9 +58,9 @@ export class ConfirmationService {
5958
return this.status$;
6059
}
6160

62-
clear(status?: Toaster.Status) {
61+
clear(status?: Confirmation.Status) {
6362
this.confirmation$.next();
64-
this.status$.next(status || Toaster.Status.dismiss);
63+
this.status$.next(status || Confirmation.Status.dismiss);
6564
}
6665

6766
listenToEscape() {

0 commit comments

Comments
 (0)