Check for errors from EnsureDirectoryExists/RenameFile

The return values of these functions are not supposed to be ignored. Check them and handle appropriately. Bug: 385004915 Test: m Change-Id: I96a780dd5e8475130f2ea04ea4b7a8ffbbbb39cf

Author: adelva1984

common/libs/utils/files.cpp

@@ -186,7 +186,7 @@ Result<void> EnsureDirectoryExists(const std::string& directory_path,
  }
  const auto parent_dir = android::base::Dirname(directory_path);
  if (parent_dir.size() > 1) {
- EnsureDirectoryExists(parent_dir, mode, group_name);
+ CF_EXPECT(EnsureDirectoryExists(parent_dir, mode, group_name));
  }
  LOG(VERBOSE) << "Setting up " << directory_path;
  if (mkdir(directory_path.c_str(), mode) < 0 && errno != EEXIST) {

host/commands/assemble_cvd/vendor_dlkm_utils.cc

@@ -458,16 +458,20 @@ bool SplitRamdiskModules(const std::string& ramdisk_path,
  if (IsKernelModuleSigned(module_location)) {
  const auto system_dlkm_module_location =
  fmt::format("{}/{}", system_modules_dir, module_path);
- EnsureDirectoryExists(
+ auto res = EnsureDirectoryExists(
  android::base::Dirname(system_dlkm_module_location));
- RenameFile(module_location, system_dlkm_module_location);
+ CHECK(res.ok()) << res.error().FormatForEnv();
+ auto ret = RenameFile(module_location, system_dlkm_module_location);
+ CHECK(ret.ok()) << ret.error().FormatForEnv();
  system_dlkm_modules.emplace(module_path);
  } else {
  const auto vendor_dlkm_module_location =
  fmt::format("{}/{}", vendor_modules_dir, module_path);
- EnsureDirectoryExists(
+ auto res = EnsureDirectoryExists(
  android::base::Dirname(vendor_dlkm_module_location));
- RenameFile(module_location, vendor_dlkm_module_location);
+ CHECK(res.ok()) << res.error().FormatForEnv();
+ auto ret = RenameFile(module_location, vendor_dlkm_module_location);
+ CHECK(ret.ok()) << ret.error().FormatForEnv();
  vendor_dlkm_modules.emplace(module_path);
  }
  }
@@ -492,7 +496,8 @@ bool SplitRamdiskModules(const std::string& ramdisk_path,
  if (FileExists(initramfs_blocklist_path)) {
  const auto vendor_dlkm_blocklist_path =
  fmt::format("{}/{}", vendor_modules_dir, "modules.blocklist");
- RenameFile(initramfs_blocklist_path, vendor_dlkm_blocklist_path);
+ auto ret = RenameFile(initramfs_blocklist_path, vendor_dlkm_blocklist_path);
+ CHECK(ret.ok()) << ret.error().FormatForEnv();
  }
 
  // Write updated modules.dep and modules.load files