Add strict to tsconfig.json

Author: wooorm

index.js

@@ -1,26 +1,28 @@
+/**
+ * @typedef {import('hast').Root} Root
+ * @typedef {Root['children'][number]|Root} Node
+ */
+
 /**
  * Check whether a `node` is labelable:
  * See: <https://html.spec.whatwg.org/#category-label>.
  *
- * @param {unknown} node
+ * @param {Node} node
  * @returns {boolean}
  */
 export function labelable(node) {
- /** @type {string} */
- const name =
- // @ts-ignore Looks like an object.
- node && typeof node === 'object' && node.type === 'element' && node.tagName
-
  return Boolean(
- name === 'button' ||
- name === 'keygen' ||
- name === 'meter' ||
- name === 'output' ||
- name === 'progress' ||
- name === 'select' ||
- name === 'textarea' ||
- (name === 'input' &&
- // @ts-ignore Looks like an object.
- (node.properties && node.properties.type) !== 'hidden')
+ node &&
+ typeof node === 'object' &&
+ node.type === 'element' &&
+ (node.tagName === 'button' ||
+ node.tagName === 'keygen' ||
+ node.tagName === 'meter' ||
+ node.tagName === 'output' ||
+ node.tagName === 'progress' ||
+ node.tagName === 'select' ||
+ node.tagName === 'textarea' ||
+ (node.tagName === 'input' &&
+ (node.properties && node.properties.type) !== 'hidden'))
  )
 }

package.json

@@ -30,6 +30,9 @@
  "index.d.ts",
  "index.js"
  ],
+ "dependencies": {
+ "@types/hast": "^2.0.0"
+ },
  "devDependencies": {
  "@types/tape": "^4.0.0",
  "c8": "^7.0.0",

test.js

@@ -2,6 +2,7 @@ import test from 'tape'
 import {labelable} from './index.js'
 
 test('labelable', (t) => {
+ // @ts-expect-error: runtime.
  t.equal(labelable(), false, 'should return `false` without node')
 
  t.equal(
@@ -11,13 +12,13 @@ test('labelable', (t) => {
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'div'}),
+ labelable({type: 'element', tagName: 'div', children: []}),
  false,
  'should return `false` for non-labelable elements'
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'input'}),
+ labelable({type: 'element', tagName: 'input', children: []}),
  true,
  'should return `true` for `input` elements'
  )
@@ -26,50 +27,51 @@ test('labelable', (t) => {
  labelable({
  type: 'element',
  tagName: 'input',
- properties: {type: 'hidden'}
+ properties: {type: 'hidden'},
+ children: []
  }),
  false,
  'should return `false` for `input[type=hidden]` elements'
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'button'}),
+ labelable({type: 'element', tagName: 'button', children: []}),
  true,
  'should return `true` for `button` elements'
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'keygen'}),
+ labelable({type: 'element', tagName: 'keygen', children: []}),
  true,
  'should return `true` for `keygen` elements'
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'meter'}),
+ labelable({type: 'element', tagName: 'meter', children: []}),
  true,
  'should return `true` for `meter` elements'
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'output'}),
+ labelable({type: 'element', tagName: 'output', children: []}),
  true,
  'should return `true` for `output` elements'
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'progress'}),
+ labelable({type: 'element', tagName: 'progress', children: []}),
  true,
  'should return `true` for `progress` elements'
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'select'}),
+ labelable({type: 'element', tagName: 'select', children: []}),
  true,
  'should return `true` for `select` elements'
  )
 
  t.equal(
- labelable({type: 'element', tagName: 'textarea'}),
+ labelable({type: 'element', tagName: 'textarea', children: []}),
  true,
  'should return `true` for `textarea` elements'
  )

tsconfig.json

@@ -10,6 +10,7 @@
  "declaration": true,
  "emitDeclarationOnly": true,
  "allowSyntheticDefaultImports": true,
- "skipLibCheck": true
+ "skipLibCheck": true,
+ "strict": true
  }
 }