minor #33770 Add types to constructors and private/final/internal methods (Batch III) (derrabus)

This PR was squashed before being merged into the 4.4 branch (closes #33770). Discussion ---------- Add types to constructors and private/final/internal methods (Batch III) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #32179, #33228 | License | MIT | Doc PR | N/A Followup to #33709, this time with: * Validator * VarDumper * Workflow * Yaml * all bridges * all bundles That should be the final batch. 😃 Commits ------- 6493902287 Add types to constructors and private/final/internal methods (Batch III)

Author: nicolas-grekas

Command/ServerLogCommand.php

@@ -127,7 +127,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
  return 0;
  }
 
- private function getLogs($socket)
+ private function getLogs($socket): iterable
  {
  $sockets = [(int) $socket => $socket];
  $write = [];
@@ -150,7 +150,7 @@ private function getLogs($socket)
  }
  }
 
- private function displayLog(InputInterface $input, OutputInterface $output, $clientId, array $record)
+ private function displayLog(InputInterface $input, OutputInterface $output, int $clientId, array $record)
  {
  if (isset($record['log_id'])) {
  $clientId = unpack('H*', $record['log_id'])[1];

DependencyInjection/WebServerExtension.php

@@ -44,7 +44,7 @@ public function load(array $configs, ContainerBuilder $container)
  }
  }
 
- private function getPublicDirectory(ContainerBuilder $container)
+ private function getPublicDirectory(ContainerBuilder $container): string
  {
  $kernelProjectDir = $container->getParameter('kernel.project_dir');
  $publicDir = 'public';

WebServer.php

@@ -174,7 +174,7 @@ private function createServerProcess(WebServerConfig $config): Process
  return $process;
  }
 
- private function getDefaultPidFile()
+ private function getDefaultPidFile(): string
  {
  return ($this->pidFileDirectory ?? getcwd()).'/.web-server-pid';
  }