Skip to content

Commit 4577ce6

Browse files
committed
feature #58335 [Notifier] deprecate the TransportFactoryTestCase (xabbuh)
This PR was merged into the 7.2 branch. Discussion ---------- [Notifier] deprecate the TransportFactoryTestCase | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | Fix #54100 | License | MIT Commits ------- c8b0fcc77b deprecate the TransportFactoryTestCase
2 parents 520c93c + 31f5aa0 commit 4577ce6

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

Tests/TwilioTransportFactoryTest.php

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,15 @@
1212
namespace Symfony\Component\Notifier\Bridge\Twilio\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Twilio\TwilioTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
17+
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
1618

17-
final class TwilioTransportFactoryTest extends TransportFactoryTestCase
19+
final class TwilioTransportFactoryTest extends AbstractTransportFactoryTestCase
1820
{
21+
use IncompleteDsnTestTrait;
22+
use MissingRequiredOptionTestTrait;
23+
1924
public function createFactory(): TwilioTransportFactory
2025
{
2126
return new TwilioTransportFactory();
@@ -45,4 +50,10 @@ public static function unsupportedSchemeProvider(): iterable
4550
yield ['somethingElse://accountSid:authToken@default?from=0611223344'];
4651
yield ['somethingElse://accountSid:authToken@default']; // missing "from" option
4752
}
53+
54+
public static function incompleteDsnProvider(): iterable
55+
{
56+
yield ['twilio://:authToken@default?from=0611223344'];
57+
yield ['twilio://accountSid:@default?from=0611223344'];
58+
}
4859
}

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0"
21+
"symfony/notifier": "^7.2"
2222
},
2323
"require-dev": {
2424
"symfony/webhook": "^6.4|^7.0"

0 commit comments

Comments
 (0)