Merge branch '4.3' into 4.4

* 4.3: [Messenger] add tests to FailedMessagesShowCommand Fix the translation commands when a template contains a syntax error [Security] Fix clearing remember-me cookie after deauthentication [Validator] Update Slovenian translations [Config][ReflectionClassResource] Handle parameters with undefined constant as their default values fix dumping number-like string parameters Fix CI [Console] Fix autocomplete multibyte input support [Config] don't break on virtual stack frames in ClassExistenceResource more robust initialization from request

Author: nicolas-grekas

Http/Firewall/ContextListener.php

@@ -32,6 +32,7 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 use Symfony\Component\Security\Http\Event\DeauthenticatedEvent;
+use Symfony\Component\Security\Http\RememberMe\RememberMeServicesInterface;
 
 /**
  * ContextListener manages the SecurityContext persistence through a session.
@@ -52,6 +53,7 @@ class ContextListener extends AbstractListener implements ListenerInterface
  private $dispatcher;
  private $registered;
  private $trustResolver;
+ private $rememberMeServices;
  private $sessionTrackerEnabler;
 
  /**
@@ -136,6 +138,10 @@ public function authenticate(RequestEvent $event)
 
  if ($token instanceof TokenInterface) {
  $token = $this->refreshUser($token);
+
+ if (!$token && $this->rememberMeServices) {
+ $this->rememberMeServices->loginFail($request);
+ }
  } elseif (null !== $token) {
  if (null !== $this->logger) {
  $this->logger->warning('Expected a security token from the session, got something else.', ['key' => $this->sessionKey, 'received' => $token]);
@@ -315,4 +321,9 @@ public static function handleUnserializeCallback($class)
  {
  throw new \ErrorException('Class not found: '.$class, 0x37313bc);
  }
+
+ public function setRememberMeServices(RememberMeServicesInterface $rememberMeServices)
+ {
+ $this->rememberMeServices = $rememberMeServices;
+ }
 }

Http/Tests/Firewall/ContextListenerTest.php

@@ -36,6 +36,7 @@
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 use Symfony\Component\Security\Http\Event\DeauthenticatedEvent;
 use Symfony\Component\Security\Http\Firewall\ContextListener;
+use Symfony\Component\Security\Http\RememberMe\RememberMeServicesInterface;
 use Symfony\Contracts\Service\ServiceLocatorTrait;
 
 class ContextListenerTest extends TestCase
@@ -262,10 +263,23 @@ public function testIfTokenIsNotDeauthenticated()
  $tokenStorage = new TokenStorage();
  $badRefreshedUser = new User('foobar', 'baz');
  $goodRefreshedUser = new User('foobar', 'bar');
- $tokenStorage = $this->handleEventWithPreviousSession([new SupportingUserProvider($badRefreshedUser), new SupportingUserProvider($goodRefreshedUser)], $goodRefreshedUser, true);
+ $tokenStorage = $this->handleEventWithPreviousSession([new SupportingUserProvider($badRefreshedUser), new SupportingUserProvider($goodRefreshedUser)], $goodRefreshedUser);
  $this->assertSame($goodRefreshedUser, $tokenStorage->getToken()->getUser());
  }
 
+ public function testRememberMeGetsCanceledIfTokenIsDeauthenticated()
+ {
+ $tokenStorage = new TokenStorage();
+ $refreshedUser = new User('foobar', 'baz');
+
+ $rememberMeServices = $this->createMock(RememberMeServicesInterface::class);
+ $rememberMeServices->expects($this->once())->method('loginFail');
+
+ $tokenStorage = $this->handleEventWithPreviousSession([new NotSupportingUserProvider(), new SupportingUserProvider($refreshedUser)], null, $rememberMeServices);
+
+ $this->assertNull($tokenStorage->getToken());
+ }
+
  public function testTryAllUserProvidersUntilASupportingUserProviderIsFound()
  {
  $refreshedUser = new User('foobar', 'baz');
@@ -374,7 +388,7 @@ protected function runSessionOnKernelResponse($newToken, $original = null)
  return $session;
  }
 
- private function handleEventWithPreviousSession($userProviders, UserInterface $user = null)
+ private function handleEventWithPreviousSession($userProviders, UserInterface $user = null, RememberMeServicesInterface $rememberMeServices = null)
  {
  $user = $user ?: new User('foo', 'bar');
  $session = new Session(new MockArraySessionStorage());
@@ -399,6 +413,10 @@ private function handleEventWithPreviousSession($userProviders, UserInterface $u
  }
 
  $listener = new ContextListener($tokenStorage, $userProviders, 'context_key', null, null, null, $sessionTrackerEnabler);
+
+ if ($rememberMeServices) {
+ $listener->setRememberMeServices($rememberMeServices);
+ }
  $listener(new RequestEvent($this->getMockBuilder(HttpKernelInterface::class)->getMock(), $request, HttpKernelInterface::MASTER_REQUEST));
 
  if (null !== $usageIndex) {