[ObjectMapper] Correctly manage constructor initialization

Author: alanpoulain

ObjectMapper.php

@@ -146,7 +146,7 @@ public function map(object $source, object|string|null $target = null): object
  }
  }
 
- if (!$mappingToObject && $ctorArguments && $constructor) {
+ if (!$mappingToObject && !$map?->transform && $constructor) {
  try {
  $mappedTarget->__construct(...$ctorArguments);
  } catch (\ReflectionException $e) {

Tests/Fixtures/InitializedConstructor/A.php

@@ -0,0 +1,17 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\ObjectMapper\Tests\Fixtures\InitializedConstructor;
+
+class A
+{
+ public array $tags = ['foo', 'bar'];
+}

Tests/Fixtures/InitializedConstructor/B.php

@@ -0,0 +1,31 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\ObjectMapper\Tests\Fixtures\InitializedConstructor;
+
+class B
+{
+ public array $tags;
+
+ public function __construct()
+ {
+ $this->tags = [];
+ }
+
+ public function addTag($tag)
+ {
+ $this->tags[] = $tag;
+ }
+
+ public function removeTag($tag)
+ {
+ }
+}

Tests/ObjectMapperTest.php

@@ -32,6 +32,8 @@
 use Symfony\Component\ObjectMapper\Tests\Fixtures\Flatten\User;
 use Symfony\Component\ObjectMapper\Tests\Fixtures\Flatten\UserProfile;
 use Symfony\Component\ObjectMapper\Tests\Fixtures\HydrateObject\SourceOnly;
+use Symfony\Component\ObjectMapper\Tests\Fixtures\InitializedConstructor\A as InitializedConstructorA;
+use Symfony\Component\ObjectMapper\Tests\Fixtures\InitializedConstructor\B as InitializedConstructorB;
 use Symfony\Component\ObjectMapper\Tests\Fixtures\InstanceCallback\A as InstanceCallbackA;
 use Symfony\Component\ObjectMapper\Tests\Fixtures\InstanceCallback\B as InstanceCallbackB;
 use Symfony\Component\ObjectMapper\Tests\Fixtures\InstanceCallbackWithArguments\A as InstanceCallbackWithArgumentsA;
@@ -147,6 +149,15 @@ public function testDeeperRecursion()
  $this->assertInstanceOf(RelationDto::class, $mapped->relation);
  }
 
+ public function testMapWithInitializedConstructor()
+ {
+ $a = new InitializedConstructorA();
+ $mapper = new ObjectMapper(propertyAccessor: PropertyAccess::createPropertyAccessor());
+ $b = $mapper->map($a, InitializedConstructorB::class);
+ $this->assertInstanceOf(InitializedConstructorB::class, $b);
+ $this->assertEquals($b->tags, ['foo', 'bar']);
+ }
+
  public function testMapToWithInstanceHook()
  {
  $a = new InstanceCallbackA();