[Sema] Downgrade the redundant conformance error to a warning for conformances originally stated in CoreGraphics. #60181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| @swift-ci please smoke test |
salinas-miguel approved these changes Jul 21, 2022
hborla force-pushed the restated-coregraphics-conformance branch from 36db980 to f50fcd4 Compare Member Author
| @swift-ci please smoke test |
hborla force-pushed the restated-coregraphics-conformance branch from f50fcd4 to e7709fc Compare Member Author
| @swift-ci please smoke test |
…formances originally stated in CoreGraphics.
hborla force-pushed the restated-coregraphics-conformance branch from e7709fc to 25f10b9 Compare Member Author
| @swift-ci please smoke test |
2 similar comments
Member Author
| @swift-ci please smoke test |
Member Author
| @swift-ci please smoke test |
Member Author
| @swift-ci please smoke test macOS |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now that CoreFoundation is allowed to declare
CGFloatand friends, we need to adjust the redundant conformance heuristic to allow redundant conformances when the existing conformance is in CoreGraphics.Resolves: rdar://95376632