[alternative 2] reload workspace state before reloading package graph #5510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
motivation: long running host processes (ie IDEs) need this in case other SwiftPM processes (ie CLI) made changes to the state changes: * call reload state before reloading the graph * add test
tomerd changed the title Contributor Author
Member
| Just tried it and it also resolves the issue 👍 I’m fine with either this alternative or the other. |
Contributor Author
| @swift-ci smoke test |
This was referenced May 16, 2022
Closed
neonichu approved these changes May 16, 2022
abertelrud approved these changes May 16, 2022
Contributor
abertelrud left a comment
abertelrud left a comment There was a problem hiding this comment.
Looks good to me, not only given how IDEs currently interact with libSwiftPM (watching file system themselves and reloading the package graph) but also to make sure state is loaded on first load.
tomerd added a commit to tomerd/swift-package-manager that referenced this pull request May 16, 2022
motivation: long running host processes (ie IDEs) need this in case other SwiftPM processes (ie CLI) made changes to the state changes: * call reload state before reloading the graph * add test
tomerd added a commit that referenced this pull request May 17, 2022
mamouneyya reviewed May 23, 2022
| return self.storage.fileExists() | ||
| } | ||
| | ||
| /// Returns true if the state file exists on the filesystem. |
There was a problem hiding this comment.
Looks like you missed updating the doc comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
motivation: long running host processes (ie IDEs) need this in case other SwiftPM processes (ie CLI) made changes to the state
changes: