Skip to content

Commit 37ffe98

Browse files
authored
fix: prevent premature port disconnection (#159)
1 parent 46ccbd8 commit 37ffe98

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

static/background.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,6 @@ chrome.runtime.onConnect.addListener((port) => {
1212
if (message.type === 'ext/init') {
1313
ports.set(message.tabId, sender);
1414

15-
port.onDisconnect.addListener(() => {
16-
ports.delete(message.tabId);
17-
18-
if (ports.size === 0) {
19-
chrome.tabs.onUpdated.removeListener(courier);
20-
}
21-
});
22-
2315
return chrome.tabs.onUpdated.addListener(courier);
2416
} else if (message.type === 'ext/reload') {
2517
return chrome.runtime.reload();
@@ -30,6 +22,14 @@ chrome.runtime.onConnect.addListener((port) => {
3022
// relay messages from devtools page to `chrome.scripting`
3123
return chrome.tabs.sendMessage(message.tabId, message);
3224
});
25+
26+
port.onDisconnect.addListener((disconnected) => {
27+
ports.delete(+disconnected.name);
28+
29+
if (ports.size === 0) {
30+
chrome.tabs.onUpdated.removeListener(courier);
31+
}
32+
});
3333
});
3434

3535
// relay messages from `chrome.scripting` to devtools page

0 commit comments

Comments
 (0)