Taxi Booking application simplification

Author: suren-rjs

TaxiBookingApp/src/BookTaxi.java

@@ -2,60 +2,60 @@
 
 public class BookTaxi {
 
-  public static void BookNewTaxi(
-  int customerId,
-  char pickUpLocation,
-  char dropLocation,
-  int pickUpTime,
-  List<Taxi> freeTaxies) {
-  int min = 999;
-  int DistanceBetweenTaxiAndCustomer;
-  int DistanceBetweenPickupAndDrop;
-  int dropTime = 0;
-  int tripEarning = 0;
-  String tripDetails = null;
-  Taxi BookedTaxi = null;
+ public static void BookNewTaxi(
+ int customerId,
+ char pickUpLocation,
+ char dropLocation,
+ int pickUpTime,
+ List<Taxi> freeTaxies) {
+ int min = 999;
+ int DistanceBetweenTaxiAndCustomer;
+ int DistanceBetweenPickupAndDrop;
+ int dropTime = 0;
+ int tripEarning = 0;
+ String tripDetails = null;
+ Taxi BookedTaxi = null;
 
- for (Taxi currentTaxi : freeTaxies) {
- DistanceBetweenTaxiAndCustomer =
- Math.abs((currentTaxi.CurrentLocation - '0') - (pickUpLocation - '0')) * 15;
- DistanceBetweenPickupAndDrop = Math.abs((dropLocation - '0') - (pickUpLocation - '0')) * 15;
- if (DistanceBetweenTaxiAndCustomer < min) {
- BookedTaxi = currentTaxi;
- dropTime = pickUpTime + DistanceBetweenPickupAndDrop / 15;
- tripEarning = ((DistanceBetweenPickupAndDrop - 5) * 10 + 100);
- tripDetails =
- customerId
- + " "
- + customerId
- + " "
- + pickUpLocation
- + " "
- + dropLocation
- + " "
- + pickUpTime
- + " "
- + dropTime
- + " "
- + tripEarning;
- min = DistanceBetweenTaxiAndCustomer;
- }
- }
- assert BookedTaxi != null;
- BookedTaxi.BookingId = customerId;
- BookedTaxi.CurrentLocation = dropLocation;
- BookedTaxi.TotalEarnings += tripEarning;
- BookedTaxi.FreeTime = dropTime;
- BookedTaxi.TaxiDetails.add(tripDetails);
- System.out.println("Taxi -> " + BookedTaxi.TaxiNumber + " Booked !");
+ for (Taxi currentTaxi : freeTaxies) {
+ DistanceBetweenTaxiAndCustomer =
+ Math.abs((currentTaxi.CurrentLocation - '0') - (pickUpLocation - '0')) * 15;
+ DistanceBetweenPickupAndDrop = Math.abs((dropLocation - '0') - (pickUpLocation - '0')) * 15;
+ if (DistanceBetweenTaxiAndCustomer < min) {
+ BookedTaxi = currentTaxi;
+ dropTime = pickUpTime + DistanceBetweenPickupAndDrop / 15;
+ tripEarning = ((DistanceBetweenPickupAndDrop - 5) * 10 + 100);
+ tripDetails =
+ customerId
+ + " "
+ + customerId
+ + " "
+ + pickUpLocation
+ + " "
+ + dropLocation
+ + " "
+ + pickUpTime
+ + " "
+ + dropTime
+ + " "
+ + tripEarning;
+ min = DistanceBetweenTaxiAndCustomer;
+ }
  }
+ assert BookedTaxi != null;
+ BookedTaxi.BookingId = customerId;
+ BookedTaxi.CurrentLocation = dropLocation;
+ BookedTaxi.TotalEarnings += tripEarning;
+ BookedTaxi.FreeTime = dropTime;
+ BookedTaxi.TaxiDetails.add(tripDetails);
+ System.out.println("Taxi -> " + BookedTaxi.TaxiNumber + " Booked !");
+ }
 
-  public static void ShowTaxiDetails(Taxi taxi) {
-  System.out.println(
-  "BookingId CustomerId From To PickUpTime DropTime TripEarning\n");
-  for (String detail : taxi.TaxiDetails) System.out.println(detail);
-  System.out.println(
-  "Taxi " + taxi.TaxiNumber + " : Earning -> Rs. " + taxi.TotalEarnings);
- System.out.println("==================================================================================");
-  }
+ public static void ShowTaxiDetails(Taxi taxi) {
+ System.out.println(
+ "BookingId CustomerId From To PickUpTime DropTime TripEarning\n");
+ for (String detail : taxi.TaxiDetails) System.out.println(detail);
+ System.out.println(taxi);
+ System.out.println(
+ "==================================================================================");
+ }
 }

TaxiBookingApp/src/Taxi.java

@@ -20,6 +20,6 @@ public Taxi() {
  }
 
  public String toString() {
- return "";
+ return "Taxi " + this.TaxiNumber + " : Earning -> Rs. " + this.TotalEarnings;
  }
 }

TaxiBookingApp/src/TaxiBookingApplication.java

@@ -1,43 +1,28 @@
-/*
- *===================================================================================================
+/**
+ * ===================================================================================================
  *
- * No. of taxies (Assume 4)
- * 6 Points A B C D E F -> Each have 15Km between 2
- * one point to another it takes 60 mins
- * first 5km -> Rs.100 , then 10 for every Km
- * Time: Hrs (for Simplicity)
- * All taxies are initiated at A
- * When customer book taxi, free taxi will be allocated
- * two free taxies are same point -> one with lower earning will be allocated
- * Taxi charges only from customer pickup point to drop point
- * if no taxi available then booking rejected
- *________________________________________________
+ * <p>No. of taxis (Assume 4) 6 Points A B C D E F -> Each have 15Km between 2 one point to another
+ * it takes 60 min first 5km -> Rs.100 , then 10 for every Km Time: Hrs (for Simplicity) All taxis
+ * are initiated at A When customer book taxi, free taxi will be allocated two free taxis are same
+ * point -> one with lower earning will be allocated Taxi charges only from customer pickup point to
+ * drop point if no taxi available then booking rejected
+ * ________________________________________________
  *
- * Taxi :
- * TaxiNumber :
- * CurrentLocation :
- * IsBooked
- * TotalEarnings :
- * FreeTime :
- *________________________________________________
+ * <p>Taxi : TaxiNumber : CurrentLocation : IsBooked TotalEarnings : FreeTime :
+ * ________________________________________________
  *
- * BookingProcess:
- * DistanceBetweenTaxiAndCustomer -> ToFindNearestTaxi
- * DistanceBetweenPickupAndDrop -> ToCalculateFee
- * NextFreeTime -> ForNextBooking
- * NextPickupPoint -> ToAssignNextPickUpPoint
- *________________________________________________
- * (A-0)-----------(B-0)
- * 1---------------2
- * Check Taxi availability time and taxi must reach before their pickup time
+ * <p>BookingProcess: DistanceBetweenTaxiAndCustomer -> ToFindNearestTaxi
+ * DistanceBetweenPickupAndDrop -> ToCalculateFee NextFreeTime -> ForNextBooking NextPickupPoint ->
+ * ToAssignNextPickUpPoint ________________________________________________ (A-0)-----------(B-0)
+ * 1---------------2 Check Taxi availability time and taxi must reach before their pickup time
  *
- *===================================================================================================
+ * <p>===================================================================================================
  */
-
-import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Comparator;
 import java.util.List;
 import java.util.Scanner;
+import java.util.stream.Collectors;
 
 public class TaxiBookingApplication {
  static int customerId = 1;
@@ -50,8 +35,9 @@ public static void main(String[] args) {
 
  Scanner input = new Scanner(System.in);
  boolean userWantsToContinue = true;
- // Create No of Taxies
- List<Taxi> allTaxies = createTaxiList();
+ // Create No of Taxis
+ List<Taxi> allTaxis =
+ Arrays.stream(new int[4]).mapToObj(i -> new Taxi()).collect(Collectors.toList());
 
  while (userWantsToContinue) {
  System.out.println(
@@ -65,15 +51,15 @@ public static void main(String[] args) {
  char dropLocation = input.next().toUpperCase().charAt(0);
  System.out.println("\nPickUp Time = ");
  int pickUpTime = input.nextInt();
- List<Taxi> FreeTaxies = getAllFreeTaxies(pickUpTime, pickUpLocation, allTaxies);
- if (FreeTaxies.size() == 0) {
+ List<Taxi> FreeTaxis = getAllFreeTaxis(pickUpTime, pickUpLocation, allTaxis);
+ if (FreeTaxis.size() == 0) {
  System.out.println("Booking Not Available!");
  break;
  }
- BookTaxi.BookNewTaxi(customerId++, pickUpLocation, dropLocation, pickUpTime, FreeTaxies);
+ BookTaxi.BookNewTaxi(customerId++, pickUpLocation, dropLocation, pickUpTime, FreeTaxis);
  break;
  case 2:
- for (Taxi taxi : allTaxies) {
+ for (Taxi taxi : allTaxis) {
  BookTaxi.ShowTaxiDetails(taxi);
  }
  break;
@@ -86,25 +72,15 @@ public static void main(String[] args) {
  }
  }
 
- private static List<Taxi> getAllFreeTaxies(
- int PickUpTime, char PickUpLocation, List<Taxi> allTaxies) {
- List<Taxi> availableFreeTaxies = new ArrayList<>();
- for (Taxi currentTaxi : allTaxies) {
- if (currentTaxi.FreeTime <= PickUpTime
- && Math.abs((currentTaxi.CurrentLocation - '0') - (PickUpLocation - '0'))
- <= PickUpTime - currentTaxi.FreeTime) {
- availableFreeTaxies.add(currentTaxi);
- }
- }
- availableFreeTaxies.sort(Comparator.comparingInt(a -> a.TotalEarnings));
- return availableFreeTaxies;
- }
-
- private static List<Taxi> createTaxiList() {
- List<Taxi> createdTaxiList = new ArrayList<>();
- for (int i = 0; i < 4; i++) {
- createdTaxiList.add(new Taxi());
- }
- return createdTaxiList;
+ private static List<Taxi> getAllFreeTaxis(
+ int PickUpTime, char PickUpLocation, List<Taxi> allTaxis) {
+ return allTaxis.stream()
+ .filter(
+ taxi ->
+ taxi.FreeTime <= PickUpTime
+ && (Math.abs(taxi.CurrentLocation - '0') - (PickUpLocation - '0')
+ <= PickUpTime - taxi.FreeTime))
+ .sorted(Comparator.comparing(taxi -> taxi.TotalEarnings))
+ .collect(Collectors.toList());
  }
 }