✅(e2e) ensure i18n.language is injected into generated PDF

Adds an end-to-end test to verify language injection in the generated PDF. Signed-off-by: Cyril <c.gromoff@gmail.com>

Author: Ovgodd

src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts

@@ -4,7 +4,13 @@ import { expect, test } from '@playwright/test';
 import cs from 'convert-stream';
 import pdf from 'pdf-parse';
 
-import { createDoc, verifyDocName } from './utils-common';
+import {
+ TestLanguage,
+ createDoc,
+ randomName,
+ verifyDocName,
+ waitForLanguageSwitch,
+} from './utils-common';
 
 test.beforeEach(async ({ page }) => {
  await page.goto('/');
@@ -411,4 +417,71 @@ test.describe('Doc Export', () => {
  expect(pdfData.text).toContain('Column 2');
  expect(pdfData.text).toContain('Column 3');
  });
+
+ test('it injects the correct language attribute into PDF export', async ({
+ page,
+ browserName,
+ }) => {
+ await waitForLanguageSwitch(page, TestLanguage.French);
+
+ // Wait for the page to be ready after language switch
+ await page.waitForLoadState('domcontentloaded');
+
+ const header = page.locator('header').first();
+ await header.locator('h2').getByText('Docs').click();
+
+ const randomDocFrench = randomName(
+ 'doc-language-export-french',
+ browserName,
+ 1,
+ )[0];
+
+ await page
+ .getByRole('button', {
+ name: 'Nouveau doc',
+ })
+ .click();
+
+ await page.waitForURL('**/docs/**', {
+ timeout: 10000,
+ waitUntil: 'domcontentloaded',
+ });
+
+ const input = page.getByLabel('doc title input');
+ await expect(input).toBeVisible();
+ await expect(input).toHaveText('');
+ await input.click();
+ await input.fill(randomDocFrench);
+ await input.blur();
+
+ const editor = page.locator('.ProseMirror.bn-editor');
+ await editor.click();
+ await editor.fill('Contenu de test pour export en français');
+
+ await page
+ .getByRole('button', {
+ name: 'download',
+ exact: true,
+ })
+ .click();
+
+ const downloadPromise = page.waitForEvent('download', (download) => {
+ return download.suggestedFilename().includes(`${randomDocFrench}.pdf`);
+ });
+
+ void page
+ .getByRole('button', {
+ name: 'Télécharger',
+ exact: true,
+ })
+ .click();
+
+ const download = await downloadPromise;
+ expect(download.suggestedFilename()).toBe(`${randomDocFrench}.pdf`);
+
+ const pdfBuffer = await cs.toBuffer(await download.createReadStream());
+ const pdfString = pdfBuffer.toString('latin1');
+
+ expect(pdfString).toContain('/Lang (fr)');
+ });
 });

src/frontend/apps/e2e/__tests__/app-impress/language.spec.ts

@@ -1,6 +1,6 @@
 import { Page, expect, test } from '@playwright/test';
 
-import { createDoc } from './utils-common';
+import { TestLanguage, createDoc, waitForLanguageSwitch } from './utils-common';
 
 test.describe.serial('Language', () => {
  let page: Page;
@@ -94,48 +94,3 @@ test.describe.serial('Language', () => {
  await expect(page.getByText('Titres', { exact: true })).toBeVisible();
  });
 });
-
-// language helper
-export const TestLanguage = {
- English: {
- label: 'English',
- expectedLocale: ['en-us'],
- },
- French: {
- label: 'Français',
- expectedLocale: ['fr-fr'],
- },
- German: {
- label: 'Deutsch',
- expectedLocale: ['de-de'],
- },
-} as const;
-
-type TestLanguageKey = keyof typeof TestLanguage;
-type TestLanguageValue = (typeof TestLanguage)[TestLanguageKey];
-
-export async function waitForLanguageSwitch(
- page: Page,
- lang: TestLanguageValue,
-) {
- const header = page.locator('header').first();
- const languagePicker = header.locator('.--docs--language-picker-text');
- const isAlreadyTargetLanguage = await languagePicker
- .innerText()
- .then((text) => text.toLowerCase().includes(lang.label.toLowerCase()));
-
- if (isAlreadyTargetLanguage) {
- return;
- }
-
- await languagePicker.click();
- const responsePromise = page.waitForResponse(
- (resp) =>
- resp.url().includes('/user') && resp.request().method() === 'PATCH',
- );
- await page.getByLabel(lang.label).click();
- const resolvedResponsePromise = await responsePromise;
- const responseData = await resolvedResponsePromise.json();
-
- expect(lang.expectedLocale).toContain(responseData.language);
-}

src/frontend/apps/e2e/__tests__/app-impress/utils-common.ts

@@ -279,3 +279,49 @@ export const expectLoginPage = async (page: Page) =>
  ).toBeVisible({
  timeout: 10000,
  });
+// language helper
+export const TestLanguage = {
+ English: {
+ label: 'English',
+ expectedLocale: ['en-us'],
+ },
+ French: {
+ label: 'Français',
+ expectedLocale: ['fr-fr'],
+ },
+ German: {
+ label: 'Deutsch',
+ expectedLocale: ['de-de'],
+ },
+} as const;
+
+type TestLanguageKey = keyof typeof TestLanguage;
+type TestLanguageValue = (typeof TestLanguage)[TestLanguageKey];
+
+export async function waitForLanguageSwitch(
+ page: Page,
+ lang: TestLanguageValue,
+) {
+ const header = page.locator('header').first();
+ const languagePicker = header.locator('.--docs--language-picker-text');
+ const isAlreadyTargetLanguage = await languagePicker
+ .innerText()
+ .then((text) => text.toLowerCase().includes(lang.label.toLowerCase()));
+
+ if (isAlreadyTargetLanguage) {
+ return;
+ }
+
+ await languagePicker.click();
+ const responsePromise = page.waitForResponse(
+ (resp) =>
+ resp.url().includes('/user') && resp.request().method() === 'PATCH',
+ );
+ await page.getByLabel(lang.label).click();
+ const resolvedResponsePromise = await responsePromise;
+ const responseData = (await resolvedResponsePromise.json()) as {
+ language: string;
+ };
+
+ expect(lang.expectedLocale).toContain(responseData.language);
+}

src/frontend/apps/impress/src/features/docs/doc-export/components/ModalExport.tsx

@@ -97,7 +97,7 @@ export const ModalExport = ({ onClose, doc }: ModalExportProps) => {
  exportDocument,
  )) as React.ReactElement<DocumentProps>;
 
- // Inject language="fr-FR" for screen reader support
+ // Inject language for screen reader support
  const pdfDocument = isValidElement(rawPdfDocument)
  ? cloneElement(rawPdfDocument, { language: i18next.language })
  : rawPdfDocument;