Cosmetics: address cppcheck warnings on src/variables

Author: zimmerle

src/variables/duration.h

@@ -30,7 +30,7 @@ namespace variables {
 
 class Duration : public Variable {
  public:
- explicit Duration(std::string _name)
+ explicit Duration(const std::string &_name)
  : Variable(_name),
  m_retName("DURATION") { }
 

src/variables/env.h

@@ -30,7 +30,7 @@ namespace variables {
 
 class Env : public Variable {
  public:
- explicit Env(std::string _name)
+ explicit Env(const std::string &_name)
  : Variable(_name) { }
 
  void evaluate(Transaction *transaction,

src/variables/global.h

@@ -34,7 +34,7 @@ namespace variables {
 
 class Global_DictElement : public Variable {
  public:
- explicit Global_DictElement(std::string dictElement)
+ explicit Global_DictElement(const std::string &dictElement)
  : Variable("GLOBAL:" + dictElement),
  m_dictElement("GLOBAL:" + dictElement) { }
 
@@ -67,7 +67,7 @@ class Global_NoDictElement : public Variable {
 
 class Global_DictElementRegexp : public VariableRegex {
  public:
- explicit Global_DictElementRegexp(std::string dictElement)
+ explicit Global_DictElementRegexp(const std::string &dictElement)
  : VariableRegex("GLOBAL", dictElement),
  m_dictElement(dictElement) { }
 
@@ -100,13 +100,13 @@ class Global_DynamicElement : public Variable {
  t->m_rules->m_secWebAppId.m_value, l, m_keyExclusion);
  }
 
- void del(Transaction *t, std::string k) {
+ static void del(Transaction *t, const std::string &k) {
  t->m_collections.m_global_collection->del(k,
  t->m_collections.m_global_collection_key,
  t->m_rules->m_secWebAppId.m_value);
  }
 
- void storeOrUpdateFirst(Transaction *t, std::string var,
+ static void storeOrUpdateFirst(Transaction *t, std::string var,
  std::string value) {
  t->m_collections.m_global_collection->storeOrUpdateFirst(
  var, t->m_collections.m_global_collection_key,

src/variables/highest_severity.h

@@ -30,7 +30,7 @@ namespace variables {
 
 class HighestSeverity : public Variable {
  public:
- explicit HighestSeverity(std::string _name)
+ explicit HighestSeverity(const std::string &_name)
  : Variable(_name)
  { }
 

src/variables/ip.h

@@ -34,7 +34,7 @@ namespace variables {
 
 class Ip_DictElement : public Variable {
  public:
- explicit Ip_DictElement(std::string dictElement)
+ explicit Ip_DictElement(const std::string &dictElement)
  : Variable("IP:" + dictElement),
  m_dictElement("IP:" + dictElement) { }
 
@@ -67,7 +67,7 @@ class Ip_NoDictElement : public Variable {
 
 class Ip_DictElementRegexp : public VariableRegex {
  public:
- explicit Ip_DictElementRegexp(std::string dictElement)
+ explicit Ip_DictElementRegexp(const std::string &dictElement)
  : VariableRegex("IP", dictElement),
  m_dictElement(dictElement) { }
 
@@ -99,14 +99,14 @@ class Ip_DynamicElement : public Variable {
  t->m_rules->m_secWebAppId.m_value, l, m_keyExclusion);
  }
 
- void del(Transaction *t, std::string k) {
+ static void del(Transaction *t, const std::string &k) {
  t->m_collections.m_ip_collection->del(k,
  t->m_collections.m_ip_collection_key,
  t->m_rules->m_secWebAppId.m_value);
  }
 
- void storeOrUpdateFirst(Transaction *t, std::string var,
- std::string value) {
+ static void storeOrUpdateFirst(Transaction *t, const std::string &var,
+ const std::string &value) {
  t->m_collections.m_ip_collection->storeOrUpdateFirst(
  var, t->m_collections.m_ip_collection_key,
  t->m_rules->m_secWebAppId.m_value,

src/variables/modsec_build.h

@@ -32,7 +32,7 @@ namespace variables {
 
 class ModsecBuild : public Variable {
  public:
- explicit ModsecBuild(std::string _name)
+ explicit ModsecBuild(const std::string &_name)
  : Variable(_name),
  m_retName("MODSEC_BUILD") {
  std::ostringstream ss;

src/variables/remote_user.h

@@ -32,7 +32,7 @@ namespace variables {
 
 class RemoteUser : public Variable {
  public:
- explicit RemoteUser(std::string _name)
+ explicit RemoteUser(const std::string &_name)
  : Variable(_name),
  m_retName("REMOTE_USER") { }
 

src/variables/resource.h

@@ -34,7 +34,7 @@ namespace variables {
 
 class Resource_DictElement : public Variable {
  public:
- explicit Resource_DictElement(std::string dictElement)
+ explicit Resource_DictElement(const std::string &dictElement)
  : Variable("RESOURCE:" + dictElement),
  m_dictElement("RESOURCE:" + dictElement) { }
 
@@ -67,7 +67,7 @@ class Resource_NoDictElement : public Variable {
 
 class Resource_DictElementRegexp : public VariableRegex {
  public:
- explicit Resource_DictElementRegexp(std::string dictElement)
+ explicit Resource_DictElementRegexp(const std::string &dictElement)
  : VariableRegex("RESOURCE:", dictElement),
  m_dictElement(dictElement) { }
 
@@ -99,14 +99,14 @@ class Resource_DynamicElement : public Variable {
  t->m_rules->m_secWebAppId.m_value, l, m_keyExclusion);
  }
 
- void del(Transaction *t, std::string k) {
+ static void del(Transaction *t, const std::string &k) {
  t->m_collections.m_resource_collection->del(k,
  t->m_collections.m_resource_collection_key,
  t->m_rules->m_secWebAppId.m_value);
  }
 
- void storeOrUpdateFirst(Transaction *t, std::string var,
- std::string value) {
+ static void storeOrUpdateFirst(Transaction *t, const std::string &var,
+ const std::string &value) {
  t->m_collections.m_resource_collection->storeOrUpdateFirst(
  var, t->m_collections.m_resource_collection_key,
  t->m_rules->m_secWebAppId.m_value, value);

src/variables/rule.h

@@ -34,7 +34,7 @@ namespace variables {
 
 class Rule_DictElement : public VariableDictElement { \
  public:
- explicit Rule_DictElement(std::string dictElement)
+ explicit Rule_DictElement(const std::string &dictElement)
  : VariableDictElement(std::string("RULE"), dictElement) { }
 
  static void id(Transaction *t,
@@ -194,7 +194,7 @@ class Rule_DictElement : public VariableDictElement { \
 
 class Rule_DictElementRegexp : public VariableRegex {
  public:
- explicit Rule_DictElementRegexp(std::string regex)
+ explicit Rule_DictElementRegexp(const std::string &regex)
  : VariableRegex("RULE", regex) { }
 
  void evaluate(Transaction *t,

src/variables/session.h

@@ -34,7 +34,7 @@ namespace variables {
 
 class Session_DictElement : public Variable {
  public:
- explicit Session_DictElement(std::string dictElement)
+ explicit Session_DictElement(const std::string &dictElement)
  : Variable("SESSION:" + dictElement),
  m_dictElement("SESSION:" + dictElement) { }
 
@@ -67,7 +67,7 @@ class Session_NoDictElement : public Variable {
 
 class Session_DictElementRegexp : public VariableRegex {
  public:
- explicit Session_DictElementRegexp(std::string dictElement)
+ explicit Session_DictElementRegexp(const std::string &dictElement)
  : VariableRegex("SESSION", dictElement),
  m_dictElement(dictElement) { }
 
@@ -99,14 +99,14 @@ class Session_DynamicElement : public Variable {
  t->m_rules->m_secWebAppId.m_value, l, m_keyExclusion);
  }
 
- void del(Transaction *t, std::string k) {
+ static void del(Transaction *t, const std::string &k) {
  t->m_collections.m_session_collection->del(k,
  t->m_collections.m_session_collection_key,
  t->m_collections.m_ip_collection_key);
  }
 
- void storeOrUpdateFirst(Transaction *t, std::string var,
- std::string value) {
+ static void storeOrUpdateFirst(Transaction *t, const std::string &var,
+ const std::string &value) {
  t->m_collections.m_session_collection->storeOrUpdateFirst(
  var, t->m_collections.m_session_collection_key,
  t->m_rules->m_secWebAppId.m_value,