fix: remove nix from CI #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
NickLarsenNZ left a comment
NickLarsenNZ left a comment There was a problem hiding this comment.
What problem was it causing?
Just extra time, or failing?
I guess we should update niv/crate2nix when we do other version bumps. Should we add that into the developer docs (I am happy to do it)?
NickLarsenNZ approved these changes May 10, 2024
Member
NickLarsenNZ left a comment
NickLarsenNZ left a comment There was a problem hiding this comment.
Will approve anyway as I don't think there is a negative consequence here.
Member
| Please don't roll out until (stackabletech/beku.py#23 is merged and |
Member Author
| ok, thanks |
Contributor
| Also curious here, generally |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.