Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Feb 27, 2024

Install tests as needed by the operator test suite.

This makes the operator installation the responsibility of the test suite.

Advantages:

  • PR tests can now reference opreators from other PRs.
  • Only install the operators that are needed for by the test suite.
  • Running the integration tests from GH actions do not require workflows to know
    about the operator installation.

Operator installation is optional and only done if a file named tests/release.yaml is found.

Here is an release.yaml example for the trino-operator

# Contains all operators required to run the test suite. --- releases: # Do not change the name of the release as it's referenced from run_tests.sh tests: releaseDate: 1970-01-01 description: Integration test products: commons: operatorVersion: 0.0.0-dev secret: operatorVersion: 0.0.0-dev listener: operatorVersion: 0.0.0-dev zookeeper: operatorVersion: 0.0.0-dev hdfs: operatorVersion: 0.0.0-dev hive: operatorVersion: 0.0.0-dev opa: operatorVersion: 0.0.0-dev trino: operatorVersion: 0.0.0-dev
@razvan razvan requested a review from a team February 27, 2024 14:54
@stackabletech stackabletech deleted a comment from github-actions bot Feb 27, 2024
@stackabletech stackabletech deleted a comment from github-actions bot Feb 27, 2024
@stackabletech stackabletech deleted a comment from github-actions bot Feb 27, 2024
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though haven't tried to test the workflow yet.

@razvan razvan requested a review from adwk67 February 29, 2024 13:13
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
maltesander
maltesander previously approved these changes Feb 29, 2024
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just nitpicking.

razvan and others added 2 commits February 29, 2024 14:36
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 5acb774 Feb 29, 2024
@razvan razvan deleted the feat/test-release branch February 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants