Add rustfmt.toml to configure formatter #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
6 tasks
Member
| The "issue" with this is, that it requires the unstable toolchain to work, so we won't introduce any checks around this, the file is purely there as an offer, if you want to use it in your operator then that is fine and this way we ensure that is is configured the same everywhere, but if you don't feel like switching to the nightly chain to run this then that is fine too. |
soenkeliebau approved these changes May 10, 2022
Contributor
| For what it's worth, you can run a single cargo command using the nightly toolchain by using Rust-Analyzer should also allow you to set rustfmt-specific flags (for Emacs, put |
Member Author
| Let's try that out |
Member Author
| bors r+ |
bors bot pushed a commit that referenced this pull request May 13, 2022
Merge this after stackabletech/secret-operator#125 get's merged and didn't case any problems I had a quick chat with @soenkeliebau and we agreed to give it a try
| Timed out. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Merge this after stackabletech/secret-operator#125 get's merged and didn't case any problems
I had a quick chat with @soenkeliebau and we agreed to give it a try