Skip to content

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Dec 30, 2022

Description

  • Enable logging for namenode, datanode, journalnode containers as well as the namenode side container ZKFC.
  • Snafufied the whole operator
  • Refactored container handling
  • Local integration tests work

fixes #288

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/49/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team December 30, 2022 12:32
@maltesander maltesander self-assigned this Dec 30, 2022
@maltesander maltesander marked this pull request as ready for review January 6, 2023 14:37
@maltesander maltesander requested a review from sbernauer January 12, 2023 15:38
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 16, 2023
# Description - Enable logging for namenode, datanode, journalnode containers as well as the namenode side container ZKFC. - Snafufied the whole operator - Refactored container handling - Local integration tests work fixes #288 test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/49/ ## Review Checklist - [x] Code contains useful comments - [x] CRD change approved (or not applicable) - [x] (Integration-)Test cases added (or not applicable) - [x] Documentation added (or not applicable) - [x] Changelog updated (or not applicable) - [x] Cargo.toml only contains references to git tags (not specific commits or branches) - [x] Helm chart can be installed and deployed operator works (or not applicable) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests) Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 16, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable Log Aggregation for HDFS [Merged by Bors] - Enable Log Aggregation for HDFS Jan 16, 2023
@bors bors bot closed this Jan 16, 2023
@bors bors bot deleted the enable-logging branch January 16, 2023 11:28
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

4 participants