Skip to content

Commit c709e2d

Browse files
committed
review changes
1 parent abdb2b1 commit c709e2d

File tree

21 files changed

+75
-22
lines changed

21 files changed

+75
-22
lines changed

1-Authentication/1-sign-in/AppCreationScripts/sample.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"Sample": {
3-
"Title": "Angular single-page application using MSAL Angular to sign-in users against Azure Active Directory",
3+
"Title": "Angular single-page application using MSAL Angular to sign-in users with Azure Active Directory",
44
"Level": 100,
55
"Client": "Angular SPA",
66
"RepositoryUrl": "ms-identity-javascript-angular-tutorial",

1-Authentication/1-sign-in/README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Angular single-page application using MSAL Angular to sign-in users against Azure Active Directory
1+
# Angular single-page application using MSAL Angular to sign-in users with Azure Active Directory
22

33
1. [Overview](#overview)
44
1. [Scenario](#scenario)
@@ -121,7 +121,7 @@ Open the project in your IDE (like Visual Studio or Visual Studio Code) to confi
121121

122122
> In the steps below, "ClientID" is the same as "Application ID" or "AppId".
123123
124-
1. Open the `App\src\app\auth-config.ts` file.
124+
1. Open the `SPA\src\app\auth-config.ts` file.
125125
1. Find the key `Enter_the_Application_Id_Here` and replace the existing value with the application ID (clientId) of `msal-angular-spa` app copied from the Azure portal.
126126
1. Find the key `Enter_the_Tenant_Info_Here` and replace the existing value with the tenant ID of `msal-angular-spa` app copied from the Azure portal.
127127

@@ -147,8 +147,6 @@ Were we successful in addressing your learning objective? Consider taking a mome
147147

148148
## About the code
149149

150-
MSAL Angular is a wrapper around MSAL.js.
151-
152150
### Configuration
153151

154152
You can initialize your application in several ways, for instance, by loading the configuration parameters from another server. See [Configuration Options](https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/docs/v2-docs/configuration.md) for more information.
@@ -216,7 +214,7 @@ When you receive an [ID token](https://docs.microsoft.com/azure/active-directory
216214
217215
For instance, to configure this sample for **Azure AD Germany** National Cloud:
218216
219-
1. Open the `src\app\app-config.json` file.
217+
1. Open the `src\app\auth-config.ts` file.
220218
1. Find the app key `Enter_the_Application_Id_Here` and replace the existing value with the application ID (clientId) of the `ms-identity-javascript-angular-signin` application copied from the Azure portal.
221219
1. Find the app key `https://login.microsoftonline.com/Enter_the_Tenant_Info_Here` and replace the existing value with `https://portal.microsoftazure.de/<your-tenant-id>`.
222220

-23.3 KB
Binary file not shown.

1-Authentication/1-sign-in/SPA/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "ms-identity-angular-c1s1",
33
"version": "1.0.0",
4-
"description": "Angular single-page application using MSAL React to sign-in users against Azure Active Directory",
4+
"description": "Angular single-page application using MSAL React to sign-in users with Azure Active Directory",
55
"scripts": {
66
"ng": "ng",
77
"start": "ng serve",

1-Authentication/1-sign-in/SPA/src/app/app.component.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,9 @@
55
a.title {
66
color: white;
77
}
8+
9+
.footer-text {
10+
font-size: small;
11+
text-align: center;
12+
flex: 1 1 auto;
13+
}

1-Authentication/1-sign-in/SPA/src/app/app.component.html

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,12 @@
1010
<div class="container">
1111
<!--This is to avoid reload during acquireTokenSilent() because of hidden iframe -->
1212
<router-outlet *ngIf="!isIframe"></router-outlet>
13-
</div>
13+
</div>
14+
15+
<footer *ngIf="loginDisplay">
16+
<mat-toolbar>
17+
<div class="footer-text">
18+
How did we do? <a href="https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR73pcsbpbxNJuZCMKN0lURpUOU5PNlM4MzRRV0lETkk2ODBPT0NBTEY5MCQlQCN0PWcu" target="_blank"> Share your experience with us!</a>
19+
</div>
20+
</mat-toolbar>
21+
</footer>

1-Authentication/1-sign-in/SPA/src/app/home/home.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export class HomeComponent implements OnInit {
5959
getClaims(claims: any) {
6060
this.dataSource = [
6161
{id: 1, claim: "Display Name", value: claims ? claims['name'] : null},
62-
{id: 2, claim: "User Preferred Name (UPN)", value: claims ? claims['preferred_username'] : null},
62+
{id: 2, claim: "User Principal Name (UPN) (UPN)", value: claims ? claims['preferred_username'] : null},
6363
{id: 2, claim: "OID", value: claims ? claims['oid']: null}
6464
];
6565
}

1-Authentication/2-sign-in-b2c/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ Open the project in your IDE (like Visual Studio or Visual Studio Code) to confi
9898

9999
> In the steps below, "ClientID" is the same as "Application ID" or "AppId".
100100
101-
1. Open the `App\src\app\auth-config.ts` file.
101+
1. Open the `SPA\src\app\auth-config.ts` file.
102102
1. Find the key `Enter_the_Application_Id_Here` and replace the existing value with the application ID (clientId) of `msal-react-spa` app copied from the Azure portal.
103103
1. Find the key `Enter_the_Tenant_Info_Here` and replace the existing value with your Azure AD tenant name.
104104

1-Authentication/2-sign-in-b2c/SPA/src/app/app.component.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,9 @@
55
a.title {
66
color: white;
77
}
8+
9+
.footer-text {
10+
font-size: small;
11+
text-align: center;
12+
flex: 1 1 auto;
13+
}

1-Authentication/2-sign-in-b2c/SPA/src/app/app.component.html

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,12 @@
1111
<div class="container">
1212
<!--This is to avoid reload during acquireTokenSilent() because of hidden iframe -->
1313
<router-outlet *ngIf="!isIframe"></router-outlet>
14-
</div>
14+
</div>
15+
16+
<footer *ngIf="loginDisplay">
17+
<mat-toolbar>
18+
<div class="footer-text">
19+
How did we do? <a href="https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR73pcsbpbxNJuZCMKN0lURpUOU5PNlM4MzRRV0lETkk2ODBPT0NBTEY5MCQlQCN0PWcu" target="_blank"> Share your experience with us!</a>
20+
</div>
21+
</mat-toolbar>
22+
</footer>

0 commit comments

Comments
 (0)