Fixes suppression of errors using docblocks #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Before this PR following code was working, but I think after this PR it won't: /** @codeStandardsIgnoreStart */ |
| My original comment has a typo on every annotation, it should be |
gsherwood changed the title gsherwood added a commit that referenced this pull request Sep 24, 2015
Fixes suppression of errors using docblocks
gsherwood added a commit that referenced this pull request Sep 24, 2015
| Thanks for the fix and tests. Looks like a problem that came from the switch to the new comment tokenizer. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently the only acceptable way of suppressing errors is by either using single line comments:
Or doc block comments:
This commit makes it possible to suppress errors by using PHPDoc comments: