Syntax checks can fail on Windows with PHP5.6 #660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…PHP5.6 On Windows & PHP5.6, the "php -l" output an empty leading line, and make this sniff down, add flag "m" to make it work again.
gsherwood changed the title gsherwood added a commit that referenced this pull request Dec 3, 2015
| I recently made a change to fix HHVM support for this sniff in the 3.0 branch. I just ended up trimming the output before using it, so I've done the same thing in the master branch now so they are consistent. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…PHP5.6
On Windows & PHP5.6, the "php -l" output an empty leading line, and make this sniff down, add flag "m" to make it work again.