Squiz.WhiteSpace.OperatorSpacing reports negative number in short array #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks a lot for this fix. I also applied one to the Squiz.Formatting.OperatorBracket sniff at the same time. |
gsherwood changed the title 
jrfnl added a commit to jrfnl/PHP_CodeSniffer that referenced this pull request Jul 29, 2024
…ting-add-section-on-finding-issues-to-work-on CONTRIBUTING GUIDE: add section about finding issues to work on for code contributions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since
T_OPEN_SQUARE_BRACKETis replaced withT_OPEN_SHORT_ARRAYduring tokenization this should be also being detected.Also there was previously (afaik) no test for normal
array()(but this worked thanks to the long array usingT_OPEN_PARENTHESIS).