PSR1_Sniffs_Methods_CamelCapsMethodNameSniff false positives for some magic method detection #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
localheinz force-pushed the fix/psr1-camel-caps-non-magic-methods branch from 3d74a34 to 66f9cb5 Compare 
| In other words the |
| Exactly! |
localheinz force-pushed the fix/psr1-camel-caps-non-magic-methods branch 2 times, most recently from 4ebb23d to 70624ab Compare localheinz changed the title 
There was a problem hiding this comment.
Would this be worth pulling up into Generic_Sniffs_NamingConventions_CamelCapsFunctionNameSniff?
localheinz force-pushed the fix/psr1-camel-caps-non-magic-methods branch 3 times, most recently from 426a1bd to 70624ab Compare localheinz force-pushed the fix/psr1-camel-caps-non-magic-methods branch from 70624ab to 92d524d Compare | Do we have any other magic method related code in other sniffs, that needs fixing in the same manner? |
| Doesn't look like it, but there is a lot of repetition - maybe it's worth pulling this into a utility class? |
| What I was thinking if there are similar magic method code in other sniffs. I haven't checked myself. |
| But they look solid by matching |
gsherwood added a commit that referenced this pull request Feb 16, 2015
…-methods Fix: PSR1_Sniffs_Methods_CamelCapsMethodNameSniff and magic method detections
| Thanks for the fix and the test. |
gsherwood changed the title Th3Mouk added a commit to Th3Mouk/PHP_CodeSniffer that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR
PSR1_Sniffs_Methods_CamelCapsMethodNameSniffincorrectly determines thato_toStringis a magic method while it shouldn't be