PHPCBF can't fix short open tags when they are not followed by a space #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jrfnl approved these changes Apr 25, 2017
jrfnl reviewed Apr 25, 2017
| if ($fix === true) { | ||
| $phpcsFile->fixer->replaceToken($stackPtr, '<?php'); | ||
| $correctOpening = '<?php'; | ||
| if (isset($tokens[$stackPtr + 1]) && $tokens[$stackPtr + 1]['code'] !== T_WHITESPACE) { |
There was a problem hiding this comment.
You'll need to make the isset($tokens[$stackPtr + 1]) explicitely test against true for the build to pass:
if (isset($tokens[$stackPtr + 1]) === true && ...)
| @jrfnl The requested fix is pushed. Travis is failing with my commit, was it caused by some problem in my code? |
@ghunti Still a few more small code style issues to fix, nothing major - see the travis build details for pointers. |
| @jrfnl Haven't realize that phpcs uses its own standard ^_^ |
gsherwood changed the title 
| Thanks a lot for finding and fixing this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was using
phpcbfto fix some legacy files that contained short opening tags without an empty space between them and the content:<?echo(this is valid to the PHP engine)The problem is that
phpcbfwas replacing the short opening tag with a huge string like<?phpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpphpechoI've added a test that shows the failure + the fix that I found for the problem.
Keep up the good work.
Cheers