@@ -86,27 +86,25 @@ sequenceDiagram
8686```
8787
88881 . The first step is that you create a fork of the Material for MkDocs
89- repository, either [ mkdocs-material] or [ mkdocs-material-insiders]
90- (only accessible to sponsors). This provides you with a repository that you
91- can push changes to. Note that it is not possible to have more than one fork
92- of a given repository at any point in time. So, the fork you create will be
93- * the* fork you have.
89+ repository. This provides you with a repository that you can push changes to.
90+ Note that it is not possible to have more than one fork of a given repository
91+ at any point in time. So, the fork you create will be * the* fork you have.
9492
95- 2 . Once it is made, clone it to your local machine so you can start working on
93+ 1 . Once it is made, clone it to your local machine so you can start working on
9694 your changes.
9795
98- 3 . All contributions should be made through a 'topic branch' with a name that
96+ 2 . All contributions should be made through a 'topic branch' with a name that
9997 describes the work being done. This allows you to have more than one piece
10098 of work in progress and, if you are working with the public version, also
10199 shows others clearly that the code contained is work in progress. The topic
102100 branch will be relatively short-lived and will disappear at the end, when
103101 your changes have been incorporated into the codebase.
104102
105- 4 . If you intend to make any code changes, as opposed to working on
103+ 3 . If you intend to make any code changes, as opposed to working on
106104 documentation only, you will need to [ set up a development
107105 environment] ( #setting-up-a-development-environment ) .
108106
109- 5 . Next comes the iterative process of making edits, committing them to your
107+ 4 . Next comes the iterative process of making edits, committing them to your
110108 clone. Please commit in sensible chunks that constitute a piece of work
111109 instead of committing everything in one go.
112110
@@ -116,23 +114,23 @@ sequenceDiagram
116114 reviewer in mind when committing. In particular, make sure to write
117115 meaningful commit messages.
118116
119- 6 . Push your work up to your fork regularly.
117+ 5 . Push your work up to your fork regularly.
120118
121- 7 . You should also keep an eye on changes in the Material for MkDocs repository
119+ 6 . You should also keep an eye on changes in the Material for MkDocs repository
122120 you cloned. This is especially important if you work takes a while. Please
123121 try and merge any concurrent changes into your fork and into your branch
124122 regularly. You * must* do this at least once before creating a pull request,
125123 so make your life easier and do it more often so as to minimize the risk of
126124 conflicting changes.
127125
128- 8 . Once you are happy that your changes are in a state that you can describe
126+ 7 . Once you are happy that your changes are in a state that you can describe
129127 them in a * draft* pull request, you should create this. Make sure to
130128 reference any previous discussions or issues that gave rise to your work.
131129 Creating a draft is a good way to get * early* feedback on your work from the
132130 maintainer or others. You can explicitly request reviews at points where you
133131 think this would be important.
134132
135- 9 . Review your work as if you were the reviewer and fix any issues with your
133+ 8 . Review your work as if you were the reviewer and fix any issues with your
136134 work so far. Look critically at the diffs of the files that you have changed.
137135 In particular, pay attention to whether the changes are as small as possible
138136 and whether you have follow the general coding style used in the project.
@@ -144,8 +142,6 @@ sequenceDiagram
144142 folder. You may also want to make sure that relevant examples from the
145143 [ examples repository] still build fine.
146144
147- [ mkdocs-material ] : https://github.com/squidfunk/mkdocs-material
148- [ mkdocs-material-insiders ] : https://github.com/squidfunk/mkdocs-material-insiders/
149145[ examples repository ] : https://github.com/mkdocs-material/examples
150146
151147### Finalizing
@@ -243,22 +239,13 @@ repositories on GitHub. This is so that you have a repository on GitHub that
243239you can push changes to (only maintainers and collaborators have write access
244240to the original repositories).
245241
246- Fork the [ repository for the public version] if you want to make changes to
247- code that is in the public version or if you want to make changes to the
248- documentation. It is a good idea to change the name of the repository by
249- appending ` -fork ` so that people who come across it know that they have found a
250- temporary fork rather then the original or a permanent fork of the project.
251- You may also want to add a description that clarifies what the repository is for.
242+ Fork the [ repository] if you want to make changes to code or to the documentation.
243+ It is a good idea to change the name of the repository by appending ` -fork ` so
244+ that people who come across it know that they have found a temporary fork rather
245+ than the original or a permanent fork of the project. You may also want to add
246+ a description that clarifies what the repository is for.
252247
253- [ repository for the public version ] : https://github.com/squidfunk/mkdocs-material
254-
255- To make changes to functionality available only within the Insiders version,
256- fork [ the Insiders repository] . Note that the fork will be a private repository.
257- Please respect the [ terms of the Insiders program] and the spirit of the
258- Sponsorware approach used to maintain and develop Material for MkDocs.
259-
260- [ the Insiders repository ] : https://github.com/squidfunk/mkdocs-material-insiders/
261- [ terms of the Insiders program ] : https://squidfunk.github.io/mkdocs-material/insiders/license/#fair-use-policy
248+ [ repository ] : https://github.com/squidfunk/mkdocs-material
262249
263250### Setting up a development environment
264251
@@ -346,21 +333,13 @@ to build a project to serve as a test suite. It can double as documentation that
346333shows how your new feature is meant to work.
347334
348335- Test with relevant examples from the [ Material for MkDocs Examples]
349- repository. Note that to build all examples in one go you need the projects
350- plugin from Insiders but you can always build the examples individually
351- using the public version.
336+ repository.
352337
353338[ smoke tests ] : https://en.wikipedia.org/wiki/Smoke_testing_(software)
354339[ minimal reproduction ] : https://squidfunk.github.io/mkdocs-material/guides/creating-a-reproduction/
355340[ Material for MkDocs Examples ] : https://github.com/mkdocs-material/examples
356341
357- - Ideally, also test the examples in the [ examples repository] . If you are
358- working on the Insiders edition of Material for MkDocs, you can simply start a
359- build at the top level and the [ projects plugin] will build all of the examples
360- for you. If you are on the public version, you will need to build each
361- sub-project individually. We appreciate that this is a growing collection of
362- examples and you may want to prioritize those that are most relevant to the
363- functionality you change.
342+ - Ideally, also test the examples in the [ examples repository] .
364343
365344[ examples repository ] : https://github.com/mkdocs-material/examples
366345[ projects plugin ] : https://squidfunk.github.io/mkdocs-material/plugins/projects/
0 commit comments