Skip to content

Commit 33c0c45

Browse files
authored
Merge pull request #102 from square/nits
Address review feedback nits
2 parents 1fbca71 + 14c5edb commit 33c0c45

File tree

60 files changed

+60
-60
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+60
-60
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ GIT
3939
PATH
4040
remote: .
4141
specs:
42-
cocoapods-generate (2.1.0)
42+
cocoapods-generate (2.1.1)
4343
cocoapods-disable-podfile-validations (~> 0.1.1)
4444

4545
GEM

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.1.0
1+
2.1.1

lib/cocoapods/generate/installer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ def create_main_source_file(project, pod_targets, name)
410410
source_file.open('w') do |f|
411411
f << import_statements.join("\n")
412412
f << "\n" unless import_statements.empty?
413-
f << "int main() {}\n"
413+
f << "int main() { return 0; }\n"
414414
end
415415

416416
source_file

lib/cocoapods/generate/podfile_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def podfile_for_specs(specs)
8282
end
8383
pods_for_transitive_dependencies.uniq!
8484

85-
spec_names = specs.map { |s| s.root.name }
85+
spec_names = specs.map { |s| s.root.name }.to_set
8686
dependencies = generator
8787
.transitive_dependencies_by_pod
8888
.values_at(*pods_for_transitive_dependencies)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
@import Foo;
2-
int main() {}
2+
int main() { return 0; }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
@import Foo;
2-
int main() {}
2+
int main() { return 0; }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
@import Foo;
2-
int main() {}
2+
int main() { return 0; }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
@import Foo;
2-
int main() {}
2+
int main() { return 0; }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
int main() {}
1+
int main() { return 0; }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
int main() {}
1+
int main() { return 0; }

0 commit comments

Comments
 (0)