Leave units on 0 time values. #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Browsers ignore declarations in which there is a missing unit literal after the 0, since omitting the unit on non-length data types is considered invalid.
Contributor
| Thanks for the PR! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #3.
Removing the
m?sfrom_zero_req_unit_rewould've been enough to leave the units on the value, but it would've left0.0and.0uncompressed, so I created a new RE to handle that.In terms of maintaining compatibility with YUI, I'm planning to do a similar PR against that, too. There's already a PR to fix this issue, but it's been abandoned because of lack of tests; that PR also doesn't handle
0.0and.0(it just removes them?s).