DATAREST-1213 - Unproxy JDK proxy to get version information for ETag #355
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a fix for https://jira.spring.io/browse/DATAREST-1213. In some version after
org.springframework.data:spring-data-rest-webmvc:2.4.4.RELEASE, HTTP PATCH and PUT requests with a projection would fail (using PATCH/PUT with projections makes sense when using return-body-on-update/return-body-on-create).When using a projection, the payload in the
PersistentEntityResourceinRepositoryEntityControllerends up as a dynamic JDK proxy andETag.getVersionInformationfails withI'm not quite sure what's the canonical way to unproxy a JDK proxy in Spring Data, the proxy implement
TargetAwareso that seems to be an easy solution.I would be very happy if this could be reviewed and merged. This bug affects us in two projects and currently prevents us from upgrading to any recent version of Spring Boot / Spring Data in one of them.