DATAREST-647 - Removed unnecessary lookup of the entity to update.

RepositoryEntityController.patchItemResource(…) triggered an additional, unnecessary lookup of the original entity to be updated. However the resolution algorithm for PersistentEntityResource already checks the presence and rejects an invalid identifier with a ResourceNotFoundException. PersistentEntityResource now carries a boolean flag to expose whether the entity is about to be created. That allows us to avoid the additional lookup in the method handling PUT requests, too. Related tickets: DATAREST-441.

Author: odrotbohm

spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/PersistentEntityResource.java

@@ -40,6 +40,7 @@ public class PersistentEntityResource extends Resource<Object> {
 
 private final PersistentEntity<?, ?> entity;
 private final Iterable<EmbeddedWrapper> embeddeds;
+private final boolean isNew;
 
 /**
  * Creates a new {@link PersistentEntityResource} for the given {@link PersistentEntity}, content, embedded
@@ -51,14 +52,15 @@ public class PersistentEntityResource extends Resource<Object> {
  * @param embeddeds can be {@literal null}.
  */
 private PersistentEntityResource(PersistentEntity<?, ?> entity, Object content, Iterable<Link> links,
-Iterable<EmbeddedWrapper> embeddeds) {
+Iterable<EmbeddedWrapper> embeddeds, boolean isNew) {
 
 super(content, links);
 
 Assert.notNull(entity, "PersistentEntity must not be null!");
 
 this.entity = entity;
 this.embeddeds = embeddeds == null ? NO_EMBEDDEDS : embeddeds;
+this.isNew = isNew;
 }
 
 /**
@@ -88,6 +90,16 @@ public Iterable<EmbeddedWrapper> getEmbeddeds() {
 return embeddeds;
 }
 
+/**
+ * Returns whether the content of the resource is a new entity about to be created. Used to distinguish between
+ * creation and updates for incoming requests.
+ * 
+ * @return
+ */
+public boolean isNew() {
+return isNew;
+}
+
 /**
  * Creates a new {@link Builder} to create {@link PersistentEntityResource}s eventually.
  * 
@@ -159,7 +171,17 @@ public Builder withLink(Link link) {
  * @return
  */
 public PersistentEntityResource build() {
-return new PersistentEntityResource(entity, content, links, embeddeds);
+return new PersistentEntityResource(entity, content, links, embeddeds, false);
+}
+
+/**
+ * Finally creates the {@link PersistentEntityResource} instance to symbolize the contained entity is about to be
+ * created.
+ * 
+ * @return
+ */
+public PersistentEntityResource forCreation() {
+return new PersistentEntityResource(entity, content, links, embeddeds, true);
 }
 }
 }

spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/RepositoryEntityController.java

@@ -371,13 +371,12 @@ public ResponseEntity<? extends ResourceSupport> putItemResource(RootResourceInf
 RepositoryInvoker invoker = resourceInformation.getInvoker();
 Object objectToSave = incomingWrapper.getBean();
 
-Object domainObject = invoker.invokeFindOne(id);
+Object domainObject = payload.getContent();
 
 eTag.verify(resourceInformation.getPersistentEntity(), domainObject);
 
-return domainObject == null ? createAndReturn(objectToSave, invoker, assembler,
-config.returnBodyOnCreate(acceptHeader)) : saveAndReturn(objectToSave, invoker, PUT, assembler,
-config.returnBodyOnUpdate(acceptHeader));
+return payload.isNew() ? createAndReturn(objectToSave, invoker, assembler, config.returnBodyOnCreate(acceptHeader))
+: saveAndReturn(objectToSave, invoker, PUT, assembler, config.returnBodyOnUpdate(acceptHeader));
 }
 
 /**
@@ -402,15 +401,11 @@ public ResponseEntity<ResourceSupport> patchItemResource(RootResourceInformation
 
 resourceInformation.verifySupportedMethod(HttpMethod.PATCH, ResourceType.ITEM);
 
-Object domainObject = resourceInformation.getInvoker().invokeFindOne(id);
-
-if (domainObject == null) {
-throw new ResourceNotFoundException();
-}
+Object domainObject = payload.getContent();
 
 eTag.verify(resourceInformation.getPersistentEntity(), domainObject);
 
-return saveAndReturn(payload.getContent(), resourceInformation.getInvoker(), PATCH, assembler,
+return saveAndReturn(domainObject, resourceInformation.getInvoker(), PATCH, assembler,
 config.returnBodyOnUpdate(acceptHeader));
 }
 

spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/config/PersistentEntityResourceHandlerMethodArgumentResolver.java

@@ -25,6 +25,7 @@
 import org.springframework.data.repository.support.RepositoryInvoker;
 import org.springframework.data.rest.webmvc.IncomingRequest;
 import org.springframework.data.rest.webmvc.PersistentEntityResource;
+import org.springframework.data.rest.webmvc.PersistentEntityResource.Builder;
 import org.springframework.data.rest.webmvc.ResourceNotFoundException;
 import org.springframework.data.rest.webmvc.RootResourceInformation;
 import org.springframework.data.rest.webmvc.json.DomainObjectReader;
@@ -122,13 +123,16 @@ public Object resolveArgument(MethodParameter parameter, ModelAndViewContainer m
 }
 
 Serializable id = idResolver.resolveArgument(parameter, mavContainer, webRequest, binderFactory);
-Object obj = read(resourceInformation, incoming, converter, id);
+Object objectToUpdate = getObjectToUpdate(id, resourceInformation);
+boolean forUpdate = objectToUpdate != null;
+Object obj = read(resourceInformation, incoming, converter, objectToUpdate);
 
 if (obj == null) {
 throw new HttpMessageNotReadableException(String.format(ERROR_MESSAGE, domainType));
 }
 
-return PersistentEntityResource.build(obj, resourceInformation.getPersistentEntity()).build();
+Builder build = PersistentEntityResource.build(obj, resourceInformation.getPersistentEntity());
+return forUpdate ? build.build() : build.forCreation();
 }
 
 throw new HttpMessageNotReadableException(String.format(NO_CONVERTER_FOUND, domainType, contentType));
@@ -145,9 +149,7 @@ public Object resolveArgument(MethodParameter parameter, ModelAndViewContainer m
  * @return
  */
 private Object read(RootResourceInformation information, IncomingRequest request,
-HttpMessageConverter<Object> converter, Serializable id) {
-
-Object objectToUpdate = getObjectToUpdate(id, information);
+HttpMessageConverter<Object> converter, Object objectToUpdate) {
 
 // JSON + PATCH request
 if (request.isPatchRequest() && converter instanceof MappingJackson2HttpMessageConverter) {