Ability to modify OIDC provider configuration #635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
spring-projects-issues added the status: waiting-for-triage 
ghost marked this pull request as ready for review 
jgrandja added status: duplicate 
jgrandja reviewed Feb 25, 2022
...k/security/oauth2/server/authorization/oidc/web/OidcProviderConfigurationEndpointFilter.java Outdated Show resolved Hide resolved
jgrandja requested changes Mar 11, 2022
Collaborator
jgrandja left a comment
jgrandja left a comment There was a problem hiding this comment.
Thanks for the updates @ovidiupopa91. Please see review comments.
As well, we should add a customization hook in OidcConfigurer, for example providerConfigurationResponseConverter()
| * | ||
| * @since 0.2.3 | ||
| */ | ||
| public void setProviderConfigurationParametersConverter( |
Collaborator
There was a problem hiding this comment.
Let's rename to setProviderConfigurationResponseConverter()
| verify(filterChain).doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class)); | ||
| } | ||
| @Test | ||
| public void providerConfigurationParametersConverterWhenCustomThenAbleToOverride() throws Exception{ |
Collaborator
There was a problem hiding this comment.
Please rename method to be consistent with other methods...should start with doFilter...
Collaborator
| Hi @ovidiupopa91. I'm just circling back to this PR now. Are you still available to work on this? No worries if you don't have time. Please let me know either way. Thanks. |
Collaborator
| Hi @ovidiupopa91. I'm assuming you've been busy so I went ahead and merged this enhancement via 0994a1e. |
jgrandja added status: declined Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes gh-616