Skip to content

Conversation

@jprinet
Copy link
Contributor

@jprinet jprinet commented Nov 19, 2021

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 19, 2021
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jprinet. Please see review comment.


plugins {
id "com.gradle.enterprise" version "3.5.1"
id "com.gradle.enterprise" version "3.7.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jprinet Is there a specific reason to bump to 3.7.2? Typically, io.spring.ge.conventions is bumped when com.gradle.enterprise is bumped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jgrandja and sorry for the late response.

I don't know how your build logic is implemented but I know for sure that your plugin version is outdated:
https://ge.spring.io/s/d5rbpayhwdho4/plugins#com.gradle.enterprise-22

Here you can find the accurate list of improvements and fixes since 3.5.1:
https://docs.gradle.com/enterprise/gradle-plugin/#release_history

@jgrandja jgrandja added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 8, 2021
@jgrandja jgrandja self-assigned this Dec 8, 2021
@jgrandja jgrandja assigned sjohnr and unassigned jgrandja Jan 5, 2022
@sjohnr
Copy link
Contributor

sjohnr commented Jan 10, 2022

Closing in favor of #547.

@sjohnr sjohnr closed this Jan 10, 2022
@sjohnr sjohnr added status: blocked An issue that's blocked on an external project change status: declined A suggestion or change that we don't feel we should currently apply and removed type: dependency-upgrade A dependency upgrade status: blocked An issue that's blocked on an external project change labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

4 participants