Skip to content

Commit 84de3d2

Browse files
spring-operatorspring-operator
committed
URL Cleanup
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * [ ] http://www.ultraq.net.nz/thymeleaf/layout (302) with 4 occurrences migrated to: https://github.com/ultraq/thymeleaf-layout-dialect ([https](https://www.ultraq.net.nz/thymeleaf/layout) result ConnectTimeoutException). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://example.com/webhook with 4 occurrences migrated to: https://example.com/webhook ([https](https://example.com/webhook) result 200). * [ ] http://spring.io/spring-security with 1 occurrences migrated to: https://spring.io/spring-security ([https](https://spring.io/spring-security) result 200). * [ ] http://www.thymeleaf.org with 4 occurrences migrated to: https://www.thymeleaf.org ([https](https://www.thymeleaf.org) result 200). # Ignored These URLs were intentionally ignored. * http://localhost/oauth2/authorization/github with 1 occurrences
1 parent 725718e commit 84de3d2

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

‎src/main/resources/templates/error/403.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
-->
1616

1717
<!doctype html>
18-
<html lang="en" xmlns:th="http://www.thymeleaf.org" xmlns:layout="http://www.ultraq.net.nz/thymeleaf/layout" layout:decorate="~{layout}">
18+
<html lang="en" xmlns:th="https://www.thymeleaf.org" xmlns:layout="https://github.com/ultraq/thymeleaf-layout-dialect" layout:decorate="~{layout}">
1919
<head>
2020
<meta charset="utf-8">
2121
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

‎src/main/resources/templates/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
-->
1616

1717
<!doctype html>
18-
<html lang="en" xmlns:th="http://www.thymeleaf.org" xmlns:layout="http://www.ultraq.net.nz/thymeleaf/layout" layout:decorate="~{layout}">
18+
<html lang="en" xmlns:th="https://www.thymeleaf.org" xmlns:layout="https://github.com/ultraq/thymeleaf-layout-dialect" layout:decorate="~{layout}">
1919
<head>
2020
<meta charset="utf-8"/>
2121
<title>Add WebHook</title>

‎src/main/resources/templates/layout.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
-->
1616

1717
<!doctype html>
18-
<html xmlns:th="http://www.thymeleaf.org" xmlns:layout="http://www.ultraq.net.nz/thymeleaf/layout">
18+
<html xmlns:th="https://www.thymeleaf.org" xmlns:layout="https://github.com/ultraq/thymeleaf-layout-dialect">
1919
<head>
2020
<meta charset="utf-8">
2121
<meta http-equiv="X-UA-Compatible" content="IE=edge">

‎src/main/resources/templates/logout.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
-->
1616

1717
<!doctype html>
18-
<html lang="en" xmlns:th="http://www.thymeleaf.org" xmlns:layout="http://www.ultraq.net.nz/thymeleaf/layout" layout:decorate="~{layout}">
18+
<html lang="en" xmlns:th="https://www.thymeleaf.org" xmlns:layout="https://github.com/ultraq/thymeleaf-layout-dialect" layout:decorate="~{layout}">
1919
<head>
2020
<meta charset="utf-8">
2121
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

‎src/test/kotlin/io/spring/github/GithubHooksControllerTest.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3326,7 +3326,7 @@ class GithubHooksControllerTest {
33263326
"ssh_url": "git@github.com:spring-projects/spring-security.git",
33273327
"clone_url": "https://github.com/spring-projects/spring-security.git",
33283328
"svn_url": "https://github.com/spring-projects/spring-security",
3329-
"homepage": "http://spring.io/spring-security",
3329+
"homepage": "https://spring.io/spring-security",
33303330
"size": 33219,
33313331
"stargazers_count": 2994,
33323332
"watchers_count": 2994,

‎src/test/kotlin/io/spring/github/api/WebClientGitHubApiTest.kt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ class WebClientGitHubApiTest {
115115
],
116116
"active": true,
117117
"config": {
118-
"url": "http://example.com/webhook",
118+
"url": "https://example.com/webhook",
119119
"content_type": "json"
120120
},
121121
"updated_at": "2011-09-06T20:39:23Z",
@@ -152,7 +152,7 @@ class WebClientGitHubApiTest {
152152
],
153153
"active": true,
154154
"config": {
155-
"url": "http://example.com/webhook",
155+
"url": "https://example.com/webhook",
156156
"content_type": "json"
157157
},
158158
"updated_at": "2011-09-06T20:39:23Z",
@@ -171,7 +171,7 @@ class WebClientGitHubApiTest {
171171
],
172172
"active": true,
173173
"config": {
174-
"url": "http://example.com/webhook",
174+
"url": "https://example.com/webhook",
175175
"content_type": "json"
176176
},
177177
"updated_at": "2011-09-06T20:39:23Z",
@@ -227,7 +227,7 @@ class WebClientGitHubApiTest {
227227
],
228228
"active": true,
229229
"config": {
230-
"url": "http://example.com/webhook",
230+
"url": "https://example.com/webhook",
231231
"content_type": "json"
232232
},
233233
"updated_at": "2011-09-06T20:39:23Z",

0 commit comments

Comments
 (0)