Skip to content
This repository was archived by the owner on Jul 9, 2022. It is now read-only.

Conversation

@a1dutch
Copy link
Contributor

@a1dutch a1dutch commented Oct 28, 2014

undoes the commented out filter to only display the gradle menu when the nature has been added.

@paulvi
Copy link
Contributor

paulvi commented Oct 29, 2014

BTW @spring-project was there plan to enable some Gradle functionality, when project is without Gradle feature?

@BoykoAlex
Copy link
Contributor

The change looks good to me.
I'd follow the M2E tooling and enable/disable Gradle features similar to the ones in M2E.
Maven menu is not available for projects without Maven nature, consequently i'd do the same for Gradle.

@paulvi
Copy link
Contributor

paulvi commented Oct 29, 2014

When developer considers migrating from Maven to Gradle, it would be help for him to launch both builds, compare dependencies etc...

@a1dutch
Copy link
Contributor Author

a1dutch commented Oct 29, 2014

It's possible to have both maven and gradle natures on the same project

BoykoAlex added a commit that referenced this pull request Oct 29, 2014
only enable gradle menu when the gradle nature is present
@BoykoAlex BoykoAlex merged commit fd90f21 into spring-attic:master Oct 29, 2014
@a1dutch
Copy link
Contributor Author

a1dutch commented Oct 29, 2014

Will this be in the nightly build tonight?

@BoykoAlex
Copy link
Contributor

I have merged your PR, but in order to do so, I had to ask you to sign the CLA first (Contributor License Agreement). Is there any chance you've signed the CLA?
You can sign it here: https://support.springsource.com/spring_eclipsecla_committer_signup

@a1dutch
Copy link
Contributor Author

a1dutch commented Oct 29, 2014

just done it

@a1dutch a1dutch deleted the disable-menu-no-nature branch October 29, 2014 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants